ulmoBackport: removed hard-coded waffle flag checks for email and push notifications#1387
Merged
awais-ansari merged 1 commit intorelease/ulmofrom Nov 24, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/ulmo #1387 +/- ##
================================================
+ Coverage 68.25% 68.63% +0.37%
================================================
Files 120 119 -1
Lines 2372 2359 -13
Branches 655 654 -1
================================================
Hits 1619 1619
+ Misses 707 694 -13
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AhtishamShahid
approved these changes
Nov 24, 2025
ayesha-waris
approved these changes
Nov 24, 2025
Member
|
We should make similar changes in https://github.com/openedx/tutor-contrib-notifications/blob/main/tutornotifications/patches/mfe-lms-production-settings so that it is inline with notification enabling plugin. cc: @bmtcril |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The flags SHOW_PUSH_CHANNEL and SHOW_EMAIL_CHANNEL explicitly check for the string 'true'. As a result, the Boolean value True was incorrectly treated as an "off" state due to this hard-coded check. Waffle flags should operate as Boolean values instead. It will cause any community instance that uses a Boolean value.
process.env.SHOW_PUSH_CHANNEL === 'true'...(getConfig().SHOW_EMAIL_CHANNEL === 'true' && { EMAIL: 'email' }),Fix
The logic for the waffle flags in the account MFE has been corrected. If a flag is empty, missing, or not available in the config, it is now considered false. Any flag with a non-empty string value is considered true.
For Example
SHOW_PUSH_CHANNEL = '', it will be treated as the flag being off.SHOW_PUSH_CHANNEL = 'true', it will be treated as the flag being on.