fix: Use redux hooks in Authn login page#1188
Conversation
29ae692 to
fade402
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
=======================================
Coverage 84.22% 84.22%
=======================================
Files 126 126
Lines 2396 2384 -12
Branches 680 677 -3
=======================================
- Hits 2018 2008 -10
+ Misses 358 356 -2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
|
I know this is still just a draft, but before making it official please include in the description the rationale behind this change. I'd like to review the PR once it's ready. Thanks! |
|
@arbrandes this PR still needs an internal review. Please review once we are done with our team's review on this. Thank you |
82f85ad to
9d54560
Compare
mubbsharanwar
left a comment
There was a problem hiding this comment.
Look's good to me.
9d54560 to
be5bd1e
Compare
be5bd1e to
35a55ac
Compare
|
Hi, @arbrandes! |
|
@arbrandes do we need to wait for your review on this? |
|
Is this still necessary? It seems it ended up being implemented in #1354. |
Description
This pull request intends to enhance the loginPage and Logistration components by adopting the React-Redux hooks
useSelectoranduseDispatchin place of the conventionalmapStateToPropsandmapDispatchToPropsfunctions. This update is aimed at improving maintainability.This work is done in an effort to make the code in Authn consistent. Currently, we are using a mix of redux hooks and
mapStateToPropsandmapDispatchToPropsfunctions.JIRA
VAN-1810
How Has This Been Tested?
Locally