feat: onboarding component recommendations on authn#1287
Open
mubbsharanwar wants to merge 1 commit into2u-mainfrom
Open
feat: onboarding component recommendations on authn#1287mubbsharanwar wants to merge 1 commit into2u-mainfrom
mubbsharanwar wants to merge 1 commit into2u-mainfrom
Conversation
syedsajjadkazmii
suggested changes
Jul 19, 2024
mubbsharanwar
force-pushed
the
manwar/VAN-1947
branch
2 times, most recently
from
85a0f72 to
186e5e9
Compare
mubbsharanwar
force-pushed
the
manwar/VAN-1947
branch
from
186e5e9 to
aaf8f85
Compare
mubbsharanwar
force-pushed
the
manwar/VAN-1947
branch
from
aaf8f85 to
74fc221
Compare
syedsajjadkazmii
approved these changes
Jul 25, 2024
| if (registrationResponse) { | ||
| window.location.href = registrationResponse.redirectUrl; | ||
| if (redirectUrl) { | ||
| window.location.href = redirectUrl; |
Contributor
There was a problem hiding this comment.
something to discuss before merging:
I think it's a security risk to redirect to redirectUrl coming in query params without verifying if its safe or not.
syedsajjadkazmii
suggested changes
Jul 29, 2024
Contributor
syedsajjadkazmii
left a comment
syedsajjadkazmii
left a comment
There was a problem hiding this comment.
blocking merge until we discuss the above ^ comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Show recommendations to the users who come from the onboarding component experience
JIRA
VAN-1947
How Has This Been Tested?
Through unit tests and manual testing