-
Notifications
You must be signed in to change notification settings - Fork 249
Feature/react query migration #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/react query migration #1629
Conversation
|
Thanks for the pull request, @jesusbalderramawgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
for some reason the lint is failing with the following files webpack.prod.config.js, .eslintrc.js and jest.config.js. |
|
assign me |
| "outDir": "dist" | ||
| }, | ||
| "include": ["*.js", ".eslintrc.js", "src/**/*", "plugins/**/*", "jest.config.ts"], | ||
| "exclude": ["*.js", ".eslintrc.js", "dist", "node_modules"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "exclude": ["*.js", ".eslintrc.js", "dist", "node_modules"] | |
| "exclude": ["dist", "node_modules"] |
This fixes the lint problems.
Description
PR to migrate this repository from Redux to React-query and React context. It closes the issue
What changed?
React context was added for client side state maintaining backward compatibility with the currents components, while Redux was changed for react query for server state management.
As it was mentioned above, the functionality was kept with changes required in some components to make it work with the new hooks. The tests were updated as well after the migration.
How Has This Been Tested?
Note:
Even though the unit tests pass, there are some things that I couldn't test manually, such as
if someone knows how to test this, please let me know.