feat: add team groups section in group configurations #1728

BryanttV · 2025-03-10T16:50:03Z

Description

This PR adds a new section (TeamGroupsSection) to the Group Configurations page. This section is necessary to render the Teams configured in each Group of the course when the functionality to connect Teams with Content Groups is enabled.

Supporting information

Screenshots

Before

After

Testing instructions

Create a Waffle Flag for your course in {lms_domain}/admin/waffle_utils/waffleflagcourseoverridemodel/
- Waffle Flag: teams.content_groups_for_teams
- Course id: [Your Course ID]
- Enabled: ✅
Enables Teams in the platform using the teams.enable_teams_app flag.
Enable teams for your course in Studio > [Your Course] > Content > Pages & Resources > Teams > Teams toggle
In the same modal of Configure teams, create a few Groups.
Then, go to the LMS > [Your Course] > Teams and create a few Teams within those Groups (Topics/team-sets)
From Studio, go to Settings > Group Configurations.
You can see the new section for each of the groups. These sections are not editable.
Also, you can create Content Groups without any problem.

add-team-groups-section-in-group-configurations.webm

Additional Information

This is how it looks in the legacy interface:

teams-groups-legacy-interface.webm

openedx-webhooks · 2025-03-10T16:50:07Z

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-03-10T19:40:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.18%. Comparing base (f900ace) to head (085e54e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1728   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files        1319     1320    +1     
  Lines       30022    30031    +9     
  Branches     6748     6750    +2     
=======================================
+ Hits        28575    28584    +9     
  Misses       1378     1378           
  Partials       69       69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dcoa

LGTM!!

@bradenmacdonald @PKulkoRaccoonGang @arbrandes I don't have permission over this repo, do you mind have a look to this PR?

open-craft-grove · 2025-04-03T15:38:03Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

PKulkoRaccoonGang

Thanks for the PR! After some testing, I have some suggestions/observations that probably don't apply to this PR. If they don't apply to your scope of work and they are valid, I don't mind moving them to a separate issue 💯

If the course unit page is enabled, the link (which is under This group controls access to:) should be followed without reloading the page.
After I create a team I get an error with status code 500
After adding a new group, the user must manually scroll the inner content of the Configure teams modal window to the newly added group. Should the modal window content be automatically scrolled to the new group block?
Is it worth showing the icon to collapse the new group creation block if it is not possible to do so until the group is created? I think this can be a bit misleading for users.

src/group-configurations/team-groups-section/TeamGroupsSection.test.jsx

src/group-configurations/team-groups-section/index.jsx

BryanttV · 2025-07-25T20:06:47Z

Hi @PKulkoRaccoonGang! Thank you for your review, and I apologize for the delay. I was busy with other things. I've already addressed your suggestions.

Regarding what you found, I agree it should be moved to a separate issue.

FYI, the 500 error has already been reported here: openedx/openedx-platform#36841, and work is in progress to fix it.

open-craft-grove · 2025-07-25T21:08:24Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-07-28T13:25:46Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

bradenmacdonald · 2025-08-08T17:03:52Z

Hey everyone, what's the status of this PR?

BryanttV · 2025-08-08T17:08:18Z

Hi @bradenmacdonald, thanks for your comment! I made the changes requested by @PKulkoRaccoonGang. The PR is ready for re-review.

bradenmacdonald · 2025-08-08T17:12:02Z

@PKulkoRaccoonGang do you have time to resume your review here?

bradenmacdonald · 2025-08-08T17:12:29Z

@BryanttV Please reach out to me if you don't hear back from him within a few days.

BryanttV · 2025-08-27T18:18:55Z

Hi @bradenmacdonald! I haven't received a response yet. I'm tagging you so we can move forward.

open-craft-grove · 2025-08-27T18:37:54Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

bradenmacdonald · 2025-08-27T20:41:12Z

Sure @BryanttV , I'll try to review soon then. Could you please merge master into this branch or rebase on master so I'm testing it as it will be when it merges?

@crathbun428 or @jmakowski1123 could one of you confirm this is good to go from a product perspective? I can see there's been extensive discussion of the proposal but it's hard for me to tell the final decision(s) and how this aligns.

open-craft-grove · 2025-08-27T21:05:37Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

BryanttV · 2025-08-28T00:57:19Z

@bradenmacdonald, thanks! rebased with master ✅

bradenmacdonald

When testing this, I found that I'm seeing some team groups listed twice. Let me know if you need more info to debug.

The legacy UI only shows them once:

Also, I'm still unable to create a new content group. It gives the error shown below:

bradenmacdonald · 2025-09-04T21:16:17Z

src/group-configurations/team-groups-section/TeamGroupsSection.test.jsx

@@ -0,0 +1,24 @@
+import { initializeMocks, render } from '../../testUtils';


Suggested change

import { initializeMocks, render } from '../../testUtils';

import { initializeMocks, render } from '@src/testUtils';

Nit: could this file be .tsx ? We prefer TypeScript for any new files.

File updated, thanks!

bradenmacdonald · 2025-09-04T21:17:42Z

src/group-configurations/team-groups-section/index.tsx

+import { AvailableGroup } from '../constants';
+import ContentGroupCard from '../content-groups-section/ContentGroupCard';


Suggested change

import { AvailableGroup } from '../constants';

import ContentGroupCard from '../content-groups-section/ContentGroupCard';

import { AvailableGroup } from '@src/group-configurations/constants';

import ContentGroupCard from '@src/group-configurations/content-groups-section/ContentGroupCard';

Thanks, done!

bradenmacdonald · 2025-09-04T21:34:24Z

src/group-configurations/__mocks__/groupConfigurationResponseMock.js

+      usage: null,
+      name: 'Team Group: My Group',
+      parameters: {
+        course_id: 'course-v1:org+101+101',


Should this be courseId ? When I rename TeamGroupsSection.test.jsx to .tsx, TypeScript says this is wrong. I guess it depends if you're mocking the raw response or the processed version that's been camelCased.

The file is mixing snake_case and camelCase. But as I see it, the response should be processed in camelCase. I updated it.

mphilbrick211 · 2025-10-29T22:09:35Z

Hi @BryanttV! Friendly ping on this.

open-craft-grove · 2025-10-29T22:21:37Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Configuration information unavailable

open-craft-grove · 2025-10-30T06:34:05Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-10-30T07:26:08Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

bradenmacdonald · 2025-12-10T23:07:42Z

@BryanttV are you still planning to finish up this PR?

BryanttV · 2025-12-10T23:38:29Z

@bradenmacdonald, thanks for the ping! Over the last few weeks I've been catching up on some pending PRs and this one of them. I'll update it as soon as possible, sorry for the delay

open-craft-grove · 2025-12-11T02:35:12Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2026-02-03T23:27:57Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

BryanttV · 2026-02-04T15:02:39Z

Hi @bradenmacdonald, sorry for the delay, I just made the requested changes!

I was testing, and everything works as expected. I couldn't reproduce the errors you reported. Could you check again with the new changes?

open-craft-grove · 2026-02-04T15:49:24Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 10, 2025

openedx-webhooks added this to Contributions Mar 10, 2025

github-project-automation bot moved this to Needs Triage in Contributions Mar 10, 2025

BryanttV marked this pull request as ready for review March 10, 2025 18:20

mphilbrick211 requested a review from a team March 11, 2025 20:45

mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Mar 11, 2025

dcoa approved these changes Apr 3, 2025

View reviewed changes

PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 3, 2025

PKulkoRaccoonGang reviewed Apr 4, 2025

View reviewed changes

src/group-configurations/team-groups-section/TeamGroupsSection.test.jsx Outdated Show resolved Hide resolved

src/group-configurations/team-groups-section/index.jsx Outdated Show resolved Hide resolved

BryanttV force-pushed the bav/add-team-groups-section-in-group-configurations branch from 1acce88 to 7267928 Compare July 25, 2025 19:30

BryanttV requested a review from PKulkoRaccoonGang July 25, 2025 20:06

openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Aug 27, 2025

BryanttV force-pushed the bav/add-team-groups-section-in-group-configurations branch from 9a0ca07 to c4d79fd Compare August 27, 2025 20:53

bradenmacdonald requested changes Sep 4, 2025

View reviewed changes

mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Sep 16, 2025

mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 29, 2025

BryanttV added 8 commits February 3, 2026 16:42

feat: add team groups section in group configurations

1e291ef

chore: solve linter errors

845f0e1

test: update TeamGroupsSection tests to use test utilities

b4c6f3f

refactor: migrate constants and TeamGroupsSection to TypeScript

f89bc07

chore: solve linter errors

a58e5b8

feat: add ts interfaces for group configurations

c06bfdf

feat: add mock data for team groups in ts

387d9f0

refactor: update import paths

d3289da

BryanttV force-pushed the bav/add-team-groups-section-in-group-configurations branch from c4d79fd to d3289da Compare February 3, 2026 22:39

BryanttV added 2 commits February 4, 2026 09:55

refactor: update mock data keys to camel case for consistency

6b19364

test: add unit tests for TeamGroupsSection component

085e54e

BryanttV requested a review from bradenmacdonald February 4, 2026 15:15

		@@ -0,0 +1,24 @@
		import { initializeMocks, render } from '../../testUtils';

		import { AvailableGroup } from '../constants';
		import ContentGroupCard from '../content-groups-section/ContentGroupCard';

feat: add team groups section in group configurations #1728

Are you sure you want to change the base?

feat: add team groups section in group configurations #1728

Uh oh!

Conversation

BryanttV commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Screenshots

Before

After

Testing instructions

Additional Information

Uh oh!

openedx-webhooks commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dcoa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

open-craft-grove commented Apr 3, 2025

Uh oh!

PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BryanttV commented Jul 25, 2025

Uh oh!

open-craft-grove commented Jul 25, 2025

Uh oh!

open-craft-grove commented Jul 28, 2025

Uh oh!

bradenmacdonald commented Aug 8, 2025

Uh oh!

BryanttV commented Aug 8, 2025

Uh oh!

bradenmacdonald commented Aug 8, 2025

Uh oh!

bradenmacdonald commented Aug 8, 2025

Uh oh!

BryanttV commented Aug 27, 2025

Uh oh!

open-craft-grove commented Aug 27, 2025

Uh oh!

bradenmacdonald commented Aug 27, 2025

Uh oh!

open-craft-grove commented Aug 27, 2025

Uh oh!

BryanttV commented Aug 28, 2025

Uh oh!

bradenmacdonald left a comment

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

BryanttV Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

BryanttV Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

BryanttV Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

mphilbrick211 commented Oct 29, 2025

Uh oh!

BryanttV commented Mar 10, 2025 •

edited

Loading

openedx-webhooks commented Mar 10, 2025 •

edited

Loading

codecov bot commented Mar 10, 2025 •

edited

Loading

dcoa left a comment •

edited

Loading