Skip to content

feat: Unit Add sidebar [FC-0114]#2837

Open
ChrisChV wants to merge 16 commits intoopenedx:masterfrom
open-craft:chris/FAL-4303-add-sidebar
Open

feat: Unit Add sidebar [FC-0114]#2837
ChrisChV wants to merge 16 commits intoopenedx:masterfrom
open-craft:chris/FAL-4303-add-sidebar

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Jan 23, 2026

Description

  • Implements the new add sidebar.
  • Which user roles will this change impact? "Course Author",
image image image

Supporting information

Testing instructions

  • Go to the unit page in a course.
  • Click the Add button in the new header. Verify that the add sidebar is open.
  • Create a Video.
  • Go to the add sidebar.
  • Create Text from a template.
  • Go to the add sidebar.
  • Create an Advanced block.
  • Test creating other blocks.
  • Go to the add sidebar and go to the Add Existing tag.
  • Test adding some components from libraries.

Other information

N/A

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 23, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 23, 2026

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ChrisChV ChrisChV marked this pull request as draft January 23, 2026 22:48
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 95.78947% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.22%. Comparing base (f900ace) to head (509453a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/course-unit/unit-sidebar/AddSidebar.tsx 93.75% 7 Missing ⚠️
src/editors/containers/ProblemEditor/index.tsx 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2837      +/-   ##
==========================================
+ Coverage   95.18%   95.22%   +0.04%     
==========================================
  Files        1319     1320       +1     
  Lines       30022    30185     +163     
  Branches     6748     6573     -175     
==========================================
+ Hits        28575    28743     +168     
- Misses       1378     1385       +7     
+ Partials       69       57      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Existing tab implemented using the ComponentPicker
- Basic component implemented in the new tab
@ChrisChV ChrisChV force-pushed the chris/FAL-4303-add-sidebar branch from b33cb44 to c944174 Compare January 26, 2026 21:28
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jan 27, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jan 27, 2026
@ChrisChV ChrisChV changed the title feat: Unit Add sidebar feat: Unit Add sidebar [FC-0114] Jan 30, 2026
@ChrisChV ChrisChV marked this pull request as ready for review January 30, 2026 01:27
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Overall it looks good.

The add sidebar even works in library sourced units, we should probably disable/hide add button and also have a check in add sidebar to disallow adding components.

<MultiLibraryProvider>
<ComponentPicker
showOnlyPublished
extraFilter={['NOT block_type = "unit"', 'NOT block_type = "section"', 'NOT block_type = "subsection"']}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV We need to come up with better filter here, it is displaying units, subsections, sections and other components from courses including course blocks.

Suggested change
extraFilter={['NOT block_type = "unit"', 'NOT block_type = "section"', 'NOT block_type = "subsection"']}
extraFilter={['type = "library_block"']}

Above change works but we need to test it a bit more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated: c16ff58

Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Looks good.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please just make the component colors more DRY by refactoring them to use CSS variables (not SCSS variables) and this is good to go as far as I'm concerned.

@bradenmacdonald
Copy link
Contributor

Thanks for those changes! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

5 participants