Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
+ Coverage 95.18% 95.22% +0.04%
==========================================
Files 1319 1320 +1
Lines 30022 30185 +163
Branches 6748 6573 -175
==========================================
+ Hits 28575 28743 +168
- Misses 1378 1385 +7
+ Partials 69 57 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Existing tab implemented using the ComponentPicker - Basic component implemented in the new tab
b33cb44 to
c944174
Compare
navinkarkera
left a comment
There was a problem hiding this comment.
@ChrisChV Overall it looks good.
The add sidebar even works in library sourced units, we should probably disable/hide add button and also have a check in add sidebar to disallow adding components.
| <MultiLibraryProvider> | ||
| <ComponentPicker | ||
| showOnlyPublished | ||
| extraFilter={['NOT block_type = "unit"', 'NOT block_type = "section"', 'NOT block_type = "subsection"']} |
There was a problem hiding this comment.
@ChrisChV We need to come up with better filter here, it is displaying units, subsections, sections and other components from courses including course blocks.
| extraFilter={['NOT block_type = "unit"', 'NOT block_type = "section"', 'NOT block_type = "subsection"']} | |
| extraFilter={['type = "library_block"']} |
Above change works but we need to test it a bit more.
navinkarkera
left a comment
There was a problem hiding this comment.
@ChrisChV Looks good.
bradenmacdonald
left a comment
There was a problem hiding this comment.
LGTM! Please just make the component colors more DRY by refactoring them to use CSS variables (not SCSS variables) and this is good to go as far as I'm concerned.
|
Thanks for those changes! ✅ |
Description
Supporting information
Testing instructions
Addbutton in the new header. Verify that the add sidebar is open.Add Existingtag.Other information
N/A
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'