Fix: Updated sign out to logout for consistency#625
Open
zubairshakoorarbisoft wants to merge 4 commits intoopenedx:masterfrom
Open
Fix: Updated sign out to logout for consistency#625zubairshakoorarbisoft wants to merge 4 commits intoopenedx:masterfrom
zubairshakoorarbisoft wants to merge 4 commits intoopenedx:masterfrom
Conversation
MaxFrank13
previously approved these changes
May 20, 2025
MaxFrank13
requested changes
May 20, 2025
Member
MaxFrank13
left a comment
MaxFrank13
left a comment
There was a problem hiding this comment.
Looks great! Although it looks like we'll need to update the snapshot for this component's test. Can you run npm test -- -u to see if that fixes it?
MaxFrank13
added
the
waiting on author
Member
|
@zubairshakoorarbisoft do you have plans to pick this back up? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Description
This PR resolves consistency of Inconsistent navigation across "Profile," "Account," and "Dashboard" pages.
🎯 Issue
Actual Result:
The "Profile," "Account," and "Dashboard" pages have different navigation lists, leading to inconsistency in the user experience. This inconsistency can confuse users and make navigation between pages less intuitive.
✅ Fix
Need to update the word from Sign Out to Logout for consistency among all the pages.
🔗 Related
Live Preview: Demo Course – Progress
Taiga Ticket: Inconsistent navigation across "Profile," "Account," and "Dashboard" pages
Related GitHub Issue: overhangio/tutor-indigo#146