-
Notifications
You must be signed in to change notification settings - Fork 5
fix: add validation to the profile if the prompt_template does not exist #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add validation to the profile if the prompt_template does not exist #121
Conversation
|
Thanks for the pull request, @efortish! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 90.74% 90.98% +0.23%
==========================================
Files 48 48
Lines 4389 4504 +115
Branches 271 277 +6
==========================================
+ Hits 3983 4098 +115
Misses 317 317
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felipemontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @efortish. The PR does exactly what it says. The code is well tested and will solve this issue.
It could still happen that an existing prompt_template is deleted and the profile becomes invalid silently. I think this is acceptable for now (same pattern as ForeignKey without CASCADE), but worth remembering as a known limitation. I'll merge this now, but If you want to document that feel free to open a new PR.
related issue: #89 (comment)
Validate
prompt_templateexistence inAIWorkflowProfileDescription
Prompt templates can be referenced by slug or UUID in workflow profiles, but there was no validation checking if the referenced template actually exists in the database. This caused silent failures at runtime — the system would fall back to inline prompts or send no custom prompt to the LLM without any warning.
Changes
template_utils.py: Added_validate_prompt_templates()function that iterates over all processors inprocessor_config, checks forprompt_templatefields, and verifies they exist in the DB viaPromptTemplate.load_prompt(). Integrated into the existing_validate_semantics()pipeline.admin.py: Addedclean()method toAIWorkflowProfileAdminFormthat builds the effective config (base template + patch) and runsvalidate_workflow_config(). Invalid prompt templates now block saving in Django Admin with a descriptive error message.Tests
Added TestValidatePromptTemplates covering: existing slug/UUID, nonexistent slug/UUID, multiple processors, mixed valid/invalid, empty/null values, and Admin form integration