Skip to content

Conversation

@BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Nov 26, 2025

Description

This PR enhances the Casbin enforcer configuration with the following improvements:

  • Adds a new CASBIN_LOG_LEVEL setting (defaults to WARNING) to control the verbosity of Casbin's internal loggers.
  • Implements _configure_logging() method to configure Casbin's logging levels before enforcer initialization
  • This reduces log noise by silencing INFO-level messages from Casbin's policy evaluation and role management, which were previously logged at every authorization check.

Testing Instructions

  1. Install this plugin.
  2. Make a permission validation using the api/authz/v1/permissions/validate/me endpoint.
  3. See the logs.

Screenshots

Before

image

After

image

Merge checklist

Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 26, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 26, 2025

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 26, 2025
@BryanttV BryanttV changed the title fix: silence verbose logging for casbin policy during enforcer initialization refactor: silence verbose logging for casbin policy during enforcer initialization Nov 26, 2025
@BryanttV BryanttV changed the title refactor: silence verbose logging for casbin policy during enforcer initialization chore: configure casbin logger Nov 26, 2025
@BryanttV BryanttV force-pushed the bav/silence-print-policy branch from 711afd3 to 4756ebc Compare November 26, 2025 23:38
@BryanttV BryanttV marked this pull request as ready for review November 26, 2025 23:52
@BryanttV BryanttV force-pushed the bav/silence-print-policy branch from 4756ebc to c83d3ca Compare November 27, 2025 16:42
@BryanttV BryanttV changed the title chore: configure casbin logger feat: add configurable logging level Nov 27, 2025
@BryanttV BryanttV force-pushed the bav/silence-print-policy branch from c83d3ca to 1ff149c Compare November 27, 2025 16:47
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing my comments :)

@mariajgrimaldi mariajgrimaldi merged commit edd7b40 into openedx:main Nov 27, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Do not log all authorization policies by default (add config flag)

3 participants