Skip to content

Comments

Updating test case code to handle feedback XBlock#11252

Merged
pmitros merged 1 commit intomasterfrom
pmitros/xblock-testcase-fixes
Jan 20, 2016
Merged

Updating test case code to handle feedback XBlock#11252
pmitros merged 1 commit intomasterfrom
pmitros/xblock-testcase-fixes

Conversation

@pmitros
Copy link
Contributor

@pmitros pmitros commented Jan 16, 2016

This will:

  • Resolve several bugs in the test framework
  • Allow us to test XBlock rendered HTML

This is the first commit of https://github.com/edx/edx-platform/pull/10747 and was reviewed there. I am extracting this so that other XBlocks can merge tests which trigger previous bugs. I will merge as soon as test are run. @cahrens

@pmitros pmitros force-pushed the pmitros/xblock-testcase-fixes branch 4 times, most recently from 0350bb2 to 8144a88 Compare January 20, 2016 18:19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll kill those in a future PR, if you don't mind. This was approved for merge, and all the test are now passing. Thanks for your help!

@pmitros pmitros force-pushed the pmitros/xblock-testcase-fixes branch from 8144a88 to b480645 Compare January 20, 2016 19:23
pmitros pushed a commit that referenced this pull request Jan 20, 2016
Updating test case code to handle feedback XBlock
@pmitros pmitros merged commit 417b0d2 into master Jan 20, 2016
@pmitros pmitros deleted the pmitros/xblock-testcase-fixes branch January 20, 2016 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants