refactor: use video block utils from xblocks-contrib package#38088
Merged
refactor: use video block utils from xblocks-contrib package#38088
Conversation
farhan
added
the
create-sandbox
farhan
force-pushed
the
farhan/use-extracted-video-block-utils
branch
from
43d6126 to
69e22e8
Compare
This was referenced Mar 6, 2026
2 tasks
salman2013
reviewed
Mar 9, 2026
salman2013
approved these changes
Mar 9, 2026
Contributor
salman2013
left a comment
salman2013
left a comment
There was a problem hiding this comment.
Based on the testing notes mentioned in the PR, I am approving this.
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Aximprovements Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use utility classes from
xblocks-contrib/videoto avoid theif-elseconditions for fixing test cases for the extracted video blockThis is the PR in which we are fixing the test cases for the extracted video block.
Following tool can be used to check the difference of the original and moved code files
https://www.diffchecker.com/text-compare/
Testing notes:
I have tested the PR on the local setup.
To save time I have created following follow-up PR:
#38123