fix: fix multiple COURSE_PUBLISHED signals being fired when saving#38126
fix: fix multiple COURSE_PUBLISHED signals being fired when saving#38126marslanabdulrauf wants to merge 1 commit intoopenedx:masterfrom
Conversation
…hedule & details page changes
|
Thanks for the pull request, @marslanabdulrauf! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Related ticket (MIT Internal)
https://github.com/mitodl/hq/issues/10266
Issue
When saving changes from "Schedule & details" course page,
COURSE_PUBLISHEDsignal is fired multiple timesDescription
This pull request improves the efficiency of the
update_from_jsonmethod in theCourseDetailsmodel by batching all database writes into a single bulk operation. This ensures that only onecourse_publishedsignal is emitted per update, preventing redundant downstream processing such as multiple git auto-exports for a single user action.Signal emission and efficiency improvements:
update_from_jsoninside a singlebulk_operationscontext on the module store, so only onecourse_publishedsignal is emitted per call, reducing unnecessary downstream tasks.Testing instructions
COURSE_PUBLISHEDsignals to be fired.NOTE: you might get 2 signals locally as frontend sends two requests in development mode.