Skip to content

fix: fix multiple COURSE_PUBLISHED signals being fired when saving#38126

Open
marslanabdulrauf wants to merge 1 commit intoopenedx:masterfrom
mitodl:marslan/10266-multiple-course-published-signals
Open

fix: fix multiple COURSE_PUBLISHED signals being fired when saving#38126
marslanabdulrauf wants to merge 1 commit intoopenedx:masterfrom
mitodl:marslan/10266-multiple-course-published-signals

Conversation

@marslanabdulrauf
Copy link
Contributor

Related ticket (MIT Internal)

https://github.com/mitodl/hq/issues/10266

Issue

When saving changes from "Schedule & details" course page, COURSE_PUBLISHED signal is fired multiple times

Description

This pull request improves the efficiency of the update_from_json method in the CourseDetails model by batching all database writes into a single bulk operation. This ensures that only one course_published signal is emitted per update, preventing redundant downstream processing such as multiple git auto-exports for a single user action.

Signal emission and efficiency improvements:

  • Wrapped all writes in update_from_json inside a single bulk_operations context on the module store, so only one course_published signal is emitted per call, reducing unnecessary downstream tasks.

Testing instructions

  1. Checkout to this branch and make sure the setup is restarted
  2. Make any changes in the course "Schedule & details" page and press save.
  3. Monitor the logs and you should not see multiple COURSE_PUBLISHED signals to be fired.
  4. To confirm the issue, you can checkout to master and repeat the above steps.

NOTE: you might get 2 signals locally as frontend sends two requests in development mode.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 9, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @marslanabdulrauf!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants