fix: authz compat layer was failing on libraries v2 keys#38131
fix: authz compat layer was failing on libraries v2 keys#38131rodmgwgu wants to merge 3 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @rodmgwgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
Follow up on #38013
The code on the RBAC AuthZ compatibility layer for course authoring was querying for all roles assigned to a user, which also included library v2 permissions, which the CourseKey class was not expecting and causing an exception.
Added filtering so only courses-v1 role assignments are returned.
Supporting information
Bug reported by @BryanttV
Testing instructions
N/A
Deadline
Verawood release