feat: added new patch to add email settings#32
feat: added new patch to add email settings#32farhaanbukhsh merged 1 commit intoopenedx:mainfrom AhtishamShahid:ahtisham/added_email_config
Conversation
farhaanbukhsh
left a comment
There was a problem hiding this comment.
@AhtishamShahid Thank you for this PR I think we should allow a way for people using tutor-contrib-notification to set the value for NOTIFICATIONS_DEFAULT_FROM_EMAIL, We need to add this in plugin.py and assign a default value to this.
And then use the value from here to set this in the file, also instead of setting it in two different places you can set it in openedx-common-settings and this should apply everywhere.
Hi , I have updated the PR and tested it with. tutor config save --set . Now users can update the email if needed. |
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
✅ I tested this: on tutor devstack, the changes are made in the config and settings files
✅ I read through the code
❌ I checked for accessibility issues
❌ Includes documentation
|
@AhtishamShahid A small nit is to add the same info in the readme file as well. |
feat: updated docs for changes
Added new patch to add email settings, this makes sure that
NOTIFICATIONS_DEFAULT_FROM_EMAILusesCONTACT_EMAILif email value is not setThis resolves this issue
#27
FYI @bmtcril @saraburns1