Conversation
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
|
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
.github/workflows/release.yml
Outdated
|
|
||
| jobs: | ||
| release: | ||
| if: github.event.pull_request.merged == true && startsWith(github.head_ref, 'bot/v') |
There was a problem hiding this comment.
I don't think this is what we want, there aren't any bot PRs in this repo are there? I'd expect the trigger above to be something like so that when we roll a release in GitHub it publishes to PyPI:
on:
release:
types: [published]
Description
Adds the workflow for PyPI release of the tutor-contrib-platform-notifications, this workflow helps to tag and publish this repo.
Useful information to include:
Testing instructions
No way to test this as of now this is taken from https://github.com/openedx/tutor-contrib-aspects/blob/main/.github/workflows/release.yaml
Private Ref: https://tasks.opencraft.com/browse/BB-10380