Feature PR | Extract Video Block from edx-platform#168
Merged
Conversation
salman2013
reviewed
Feb 24, 2026
farhan
force-pushed
the
farhan/video-block
branch
from
f2009b9 to
6938d26
Compare
farhan
force-pushed
the
farhan/video-block
branch
2 times, most recently
from
d49b34f to
7eae34b
Compare
This commit contains original code copied from edx-platform. Purpose of keeping the first commit with original code is to get help in the review process. Reviewer can easily view the next commit to view the changes done in xblocks-contrib while shifting code from the edx-platform
* fix: fix quality check for video block code * chore: update package.lock.json
farhan
force-pushed
the
farhan/video-block
branch
from
98aded9 to
389b368
Compare
farhan
force-pushed
the
farhan/video-block
branch
from
696bf60 to
1a3f16f
Compare
irtazaakram
approved these changes
Mar 4, 2026
Member
irtazaakram
left a comment
irtazaakram
left a comment
There was a problem hiding this comment.
Approved as discussed for sandbox testing.
- JavaScript bundle size difference will be validated in the sandbox.
- Python unit tests and JavaScript tests will be merged before enabling the Video Block in openedx-platform.
Contributor
@irtazaakram This can also be validated with Karma test cases Ref as these are webpack karma test cases which actually tests the bundled file. |
salman2013
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract Video Block from edx-platform
Relevant test cases PR on edx-platform:
USE_EXTRACTED_VIDEO_BLOCK=True [Sandbox is up on above PR, but can't render video block as of un-availability of public assets]
Extracted Video Block | Fix the test cases openedx-platform#37996
USE_EXTRACTED_VIDEO_BLOCK=False
Run Test cases on extracted video block | USE_EXTRACTED_VIDEO_BLOCK=False openedx-platform#38047
Following PR's have been merged in this PR:
#141
#142
#167
#143
Test PR's ✅ [In code review]:
#144 [test_video passing ✅]
#103 [Karma test cases [passing ✅ ]
Maunal testing notes:
Some basic testing of the block on local machine (tutor dev) has been done on this feature branch