Support shutdown of bootstrap server #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The call to
bootstrap.Serve
starts the provider server and blocks. In order to shutdown the server gracefully a parameter that accepts acontext
was added to support cancellation.Motivation an context
This is required by the
faas-netes
provider to support graceful shutdown and should be useful for other provider implementation as well.How has this been tested
This change was vendored into the faas-netes provider using the replace directive.
Verified the server shuts down when the context is done.
Types of changes
All providers should be updated to call
Serve
with an additional context parameter.