fix: ensure test layer is in the build DAG

Some builders will exclude layers that do not contribute to the final target layer, meaning the `ship` layer for these templates. This means that the `test` layer is often optimized away by modern builders. We add the `test` layer as a dependency of the `ship` layer to ensure it is always run. Signed-off-by: Lucas Roesler <[email protected]>
openfaas · Feb 6, 2024 · a091502 · a091502
1 parent 448f54d
commit a091502
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/template/python3-flask-debian/Dockerfile b/template/python3-flask-debian/Dockerfile
@@ -48,7 +48,7 @@ ARG TEST_ENABLED=true
 RUN [ "$TEST_ENABLED" = "false" ] && echo "skipping tests" || eval "$TEST_COMMAND"
 
 
-FROM build as ship
+FROM test as ship
 WORKDIR /home/app/
 
 #configure WSGI server and healthcheck

diff --git a/template/python3-flask/Dockerfile b/template/python3-flask/Dockerfile
@@ -46,7 +46,7 @@ ARG TEST_COMMAND=tox
 ARG TEST_ENABLED=true
 RUN [ "$TEST_ENABLED" = "false" ] && echo "skipping tests" || eval "$TEST_COMMAND"
 
-FROM build as ship
+FROM test as ship
 WORKDIR /home/app/
 
 #configure WSGI server and healthcheck

diff --git a/template/python3-http-debian/Dockerfile b/template/python3-http-debian/Dockerfile
@@ -44,7 +44,7 @@ ARG TEST_ENABLED=true
 RUN [ "$TEST_ENABLED" = "false" ] && echo "skipping tests" || eval "$TEST_COMMAND"
 
 
-FROM build as ship
+FROM test as ship
 WORKDIR /home/app/
 
 USER app

diff --git a/template/python3-http/Dockerfile b/template/python3-http/Dockerfile
@@ -43,7 +43,7 @@ ARG TEST_COMMAND=tox
 ARG TEST_ENABLED=true
 RUN [ "$TEST_ENABLED" = "false" ] && echo "skipping tests" || eval "$TEST_COMMAND"
 
-FROM build as ship
+FROM test as ship
 WORKDIR /home/app/
 
 # configure WSGI server and healthcheck