-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add minimal git version 2.25.0 in quick start doc #11412
base: main
Are you sure you want to change the base?
docs: add minimal git version 2.25.0 in quick start doc #11412
Conversation
864174b
to
57bbcf9
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! Just a note: Git 2.25.0 is a five years old release. Do we need to list minimum versions that should be common sense, because anything that old probably has severe CVEs, too? 🤔
In my opinion it is very confortable to know all minimum version when I install my dev setup. Because I don't upgrade all my tools systematically. Sometimes more informations in documentation is better than less informations |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11412 +/- ##
=======================================
Coverage 49.37% 49.37%
=======================================
Files 80 80
Lines 22604 22604
Branches 5407 5407
=======================================
Hits 11161 11161
Misses 10091 10091
Partials 1352 1352 ☔ View full report in Codecov by Sentry. |
What
I've add one ligne in doc quick start to specify that the minimal version of git is 2.25.0