Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add minimal git version 2.25.0 in quick start doc #11412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nmetifiot
Copy link

What

I've add one ligne in doc quick start to specify that the minimal version of git is 2.25.0

@nmetifiot nmetifiot requested a review from a team as a code owner February 14, 2025 09:52
@github-actions github-actions bot added the 📚 Documentation Documentation issues improve the project for everyone. label Feb 14, 2025
@nmetifiot nmetifiot force-pushed the doc/prerequisites-quick-start-quide branch from 864174b to 57bbcf9 Compare February 14, 2025 10:04
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@alexgarel alexgarel enabled auto-merge (squash) February 14, 2025 10:16
Copy link
Member

@hangy hangy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! Just a note: Git 2.25.0 is a five years old release. Do we need to list minimum versions that should be common sense, because anything that old probably has severe CVEs, too? 🤔

@nmetifiot
Copy link
Author

In my opinion it is very confortable to know all minimum version when I install my dev setup. Because I don't upgrade all my tools systematically. Sometimes more informations in documentation is better than less informations ☺️
But this PR is just a proposition.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.37%. Comparing base (5ef2c5e) to head (57bbcf9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11412   +/-   ##
=======================================
  Coverage   49.37%   49.37%           
=======================================
  Files          80       80           
  Lines       22604    22604           
  Branches     5407     5407           
=======================================
  Hits        11161    11161           
  Misses      10091    10091           
  Partials     1352     1352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Documentation Documentation issues improve the project for everyone.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants