chore: Remove outdated xml2json dependency #11437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-lock.json It is apparently only used by `scripts/obsolete/convert_gs1_xml_to_json_in_dir.js` and thus not required by prod code. Closes openfoodfacts#4894
github-actions
bot
added
the
dependencies
hangy
added
npm
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11437 +/- ##
==========================================
- Coverage 49.44% 44.55% -4.90%
==========================================
Files 80 79 -1
Lines 22627 22569 -58
Branches 5406 5397 -9
==========================================
- Hits 11188 10055 -1133
- Misses 10087 11289 +1202
+ Partials 1352 1225 -127 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove dependency on
xml2json. It's only used by an obsolete script.Related issue(s) and discussion