Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 5, 2025

Bumps actions/github-script from 7 to 8.

Release notes

Sourced from actions/github-script's releases.

v8.0.0

What's Changed

⚠️ Minimum Compatible Runner Version

v2.327.1
Release Notes

Make sure your runner is updated to this version or newer to use this release.

New Contributors

Full Changelog: actions/github-script@v7.1.0...v8.0.0

v7.1.0

What's Changed

New Contributors

Full Changelog: actions/github-script@v7...v7.1.0

... (truncated)

Commits
  • ed59741 Merge pull request #653 from actions/sneha-krip/readme-for-v8
  • 2dc352e Bold minimum Actions Runner version in README
  • 01e118c Update README for Node 24 runtime requirements
  • 8b222ac Apply suggestion from @​salmanmkc
  • adc0eea README for updating actions/github-script from v7 to v8
  • 20fe497 Merge pull request #637 from actions/node24
  • e7b7f22 update licenses
  • 2c81ba0 Update Node.js version support to 24.x
  • f28e40c Merge pull request #610 from actions/nebuk89-patch-1
  • 1ae9958 Update README.md
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8.
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@v7...v8)

---
updated-dependencies:
- dependency-name: actions/github-script
  dependency-version: '8'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 5, 2025
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 5, 2025
Copy link

This repository caches data generated from notebooks stored in other repositories in the _cookbook_data_* branches. Regenerating this cache takes about half an hour, so it is not done automatically in PRs. The current value of the cache from the main branch has been copied over to this PR's cache.

To regenerate the cache for this PR, create a comment on this PR consisting only of the string:

/regenerate-cache

@Yoshanuikabundi
Copy link
Contributor

/regenerate-cache

Copy link

A workflow has been dispatched to regenerate the cookbook cache for this PR.

  • Run ID: 18121469318
  • Triggering actor: github-actions[bot]
  • Target branch: dependabot/github_actions/actions/github-script-8
  • Deployment branch: _cookbook_data_PR108

Copy link

A workflow dispatched to regenerate the cookbook cache for this PR has just finished.

  • Run ID: 18121469318

  • Triggering actor: github-actions[bot]

  • Target branch: dependabot/github_actions/actions/github-script-8

  • Deployment branch: _cookbook_data_PR108

  • Job status: success

  • Notebooks status: 29 / 29 notebooks successfully executed (0 failures ignored)

    • [ignored]

Changes will only be visible in the ReadTheDocs preview after it has been rebuilt. You will need to be logged in to ReadTheDocs to see the rebuild option.

@Yoshanuikabundi
Copy link
Contributor

OK I think I've tested everything I reasonably can:

  • The "Generate PR cache by copying main / preprocess" failure is because this PR was opened by Dependabot. This workflow works correctly when triggered manually.
  • The manually triggered workflow correctly added the "Regenerate example notebook cache" check to the PR (this exercises two modified steps)
  • Once the cache is set up correctly, the docs build

The following things work, but these are executed from main, so they could still be broken locally:

  • /regenerate_cache works (this workflow was changed, but the version on main is still the one running)
  • All the automated comments work (though again, from main)

So there's nothing obviously broken. The only breaking change from 7-8 is upgrading from Node 20 to 24, which has numerous "SEMVER-MAJOR" changes - far too many to manually check. However, you're supposed to be able to update these things!

I'm torn as to whether to just tell dependabot to ignore github-script, or to merge this PR. I'll ask for advice at tomorrow morning's check-in.

@mattwthompson
Copy link
Member

IIUC these workflows don't publish directly if a run fails? So merging this as-is

  • if the workflows work the same as before, nothing to worry about
  • if the workflows are broken the next time they need to be run, we can fix anything script-related in that PR as needed

Not updating this workflow seems undesirable and updating it seems safe and likely a non-event, so that's what I'd favor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants