Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization multiple contracts signature #503

Merged

Conversation

kernicPanel
Copy link
Member

@kernicPanel kernicPanel commented Dec 4, 2023

Purpose

An organization owner should be able to sign multiple contracts once they are signed by a student.

Proposal

Add an API endpoint to generate a signature link for all contracts to sign.

@kernicPanel kernicPanel changed the base branch from main to signature-organization December 4, 2023 14:49
@kernicPanel kernicPanel changed the title 📝(backend) add lex persona doc links Bulk orga signature Dec 4, 2023
@kernicPanel kernicPanel force-pushed the multiple-signatures-organization branch from dfcf344 to 8d60769 Compare December 4, 2023 15:18
@kernicPanel kernicPanel force-pushed the signature-organization branch 7 times, most recently from 62280ae to eb4a9ab Compare December 5, 2023 15:44
@kernicPanel kernicPanel force-pushed the multiple-signatures-organization branch 2 times, most recently from f521529 to 632d3d3 Compare December 6, 2023 14:41
@kernicPanel kernicPanel changed the title Bulk orga signature Organization multiple contracts signature Dec 6, 2023
@kernicPanel kernicPanel marked this pull request as ready for review December 6, 2023 14:43
@kernicPanel kernicPanel force-pushed the multiple-signatures-organization branch from 632d3d3 to 3da2e53 Compare December 6, 2023 15:00
Copy link
Member

@jonathanreveille jonathanreveille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

src/backend/joanie/core/api/client.py Outdated Show resolved Hide resolved
src/backend/joanie/core/models/courses.py Show resolved Hide resolved
src/backend/joanie/core/api/client.py Outdated Show resolved Hide resolved
@kernicPanel kernicPanel force-pushed the multiple-signatures-organization branch from 3da2e53 to 81e75f0 Compare December 7, 2023 09:56
@kernicPanel kernicPanel requested a review from lunika December 7, 2023 09:58
@kernicPanel kernicPanel force-pushed the signature-organization branch from b5337bc to 2406c26 Compare December 7, 2023 13:12
@kernicPanel kernicPanel force-pushed the multiple-signatures-organization branch 2 times, most recently from f23eb96 to 31df19b Compare December 7, 2023 13:25
@kernicPanel kernicPanel force-pushed the multiple-signatures-organization branch from 31df19b to e623c69 Compare December 7, 2023 16:53
Copy link
Member

@jbpenrath jbpenrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@kernicPanel kernicPanel force-pushed the multiple-signatures-organization branch from e623c69 to 0a4e751 Compare December 11, 2023 12:37
An organization owner should be able to sign multiple contracts once
they are signed by a student.
@kernicPanel kernicPanel force-pushed the multiple-signatures-organization branch from 0a4e751 to 149fe50 Compare December 11, 2023 12:37
@kernicPanel kernicPanel merged commit 510bb8e into signature-organization Dec 12, 2023
@kernicPanel kernicPanel deleted the multiple-signatures-organization branch December 12, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants