Rlecellier/dashboard teacher layout #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_layout
branch
2 times, most recently
from
098b70f to
8082b6e
Compare
jbpenrath
reviewed
Apr 21, 2023
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_layout
branch
5 times, most recently
from
07de89f to
07a0e3c
Compare
jbpenrath
reviewed
May 4, 2023
src/frontend/js/widgets/Dashboard/components/DashboardSidebar/_styles.scss
Outdated
Show resolved
Hide resolved
...ashboard/components/TeacherProfileDashboardSidebar/components/OrganizationLinks/_styles.scss
Outdated
Show resolved
Hide resolved
src/frontend/js/widgets/Dashboard/components/DashboardSidebar/_styles.scss
Outdated
Show resolved
Hide resolved
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_layout
branch
from
07a0e3c to
ff1acc3
Compare
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_layout
branch
5 times, most recently
from
7c1e807 to
7821bf8
Compare
jbpenrath
force-pushed
the
rlecellier/dashboard_teacher_layout
branch
from
7821bf8 to
5024ef6
Compare
In order to improve styles components by components, dashboard layout styles monolith need to be split.
Apply the new dashboard design
Some deadcode sneak into scss codebase.
Apply the new design for the dashboard sidebar
rlecellier
force-pushed
the
rlecellier/dashboard_teacher_layout
branch
from
5024ef6 to
122ec46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR work's on unmerged code (parent PR here). Do not take care of the two first commit.
Purpose
Apply new design (sketch) to our dasboards
Proposal
This PR it's only about Dashboard layout, the positioning of the big blocs of the page.
All individual styles for sidebar, select, glimps, etc will be handle in dedicated PR.
I choose here to split scss in each components.
DashboardLayout/stylesget all the layout css: width, padding, margin of big blocs.Others elements like Breadcrumb, Sidebar and Filters have defined styles that do not include root padding or margin.
Screenshot