Working springfield #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out `#0047ba` is not actually orange. Abstracts out Seattle's blue and dark blue as semantically the "theme color" and the "theme color dark" outside of the variables file so these can be more generally understood. Removes `$normal-text` since this was only used in one place and replaced it with the `$base-font-color` (semantically the closest match). Sets the springfield theme to a bright red to make it simple to spot anywhere that's been missed.
These should be $base-border-radius, not a specific number.
These should be the theme color, not the base font color.
Unlike the DC codebase, we're just showing the filter toggle at all sizes (it's arguably useful for big displays too). This commit adds a new Backbone view wrapper around the `#map-controls` and captures a click event to hide-show the sidebar via CSS. It also makes the mapview full-width under the sidebar to accommodate the closed state. This is a backbone-ish expansion of the ad-hoc [reach-across-the-view-hierarchy][1] situation in the DC codebase. [1]: https://github.com/cityenergyproject/dc/blob/8014c00a84c28e0e9fef10033688ce4be94e2abe/src/app/views/map/map.js#L29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configures map to display springfield data