Fetch-only support for external storage (WebDAV/AWS 3) within the attachment editor widget #6067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ink to documentation
|
🎉 Ta-daaa, freshly created APKs are available for 50091f7: arm64-android |
nirvn
commented
Mar 8, 2025
| prepareValue(""); | ||
| if (config["StorageAuthConfigId"] !== "" && !iface.isAuthenticationConfigurationAvailable(config["StorageAuthConfigId"])) { | ||
| mainWindow.displayToast(qsTr("The external storage's authentication configuration ID is missing, please insure it is imported into QField"), "error", qsTr("Learn more"), function () { | ||
| Qt.openUrlExternally('https://docs.qfield.org/how-to/authentication/'); |
There was a problem hiding this comment.
Relevant PR that improves this page: opengisch/QField-docs#535
mohsenD98
reviewed
Mar 14, 2025
|
|
||
| Q_PROPERTY( Qgis::ContentStatus status READ status NOTIFY statusChanged ) | ||
| Q_PROPERTY( QString type READ type WRITE setType NOTIFY typeChanged ) | ||
| Q_PROPERTY( QString lastError READ lastError NOTIFY lastErrorChanged ); |
There was a problem hiding this comment.
Only this Q_PROPERTY have a ; ?
| /** | ||
| * Sets the current external storage type string. The type string must be tied to an | ||
| * external storage object that was added in the QgsApplication::externalStorageRegistry(). | ||
| * |
| @@ -451,6 +452,7 @@ void QgisMobileapp::initDeclarative( QQmlEngine *engine ) | |||
| qmlRegisterType<DrawingCanvas>( "org.qfield", 1, 0, "DrawingCanvas" ); | |||
| qmlRegisterType<SubModel>( "org.qfield", 1, 0, "SubModel" ); | |||
| qmlRegisterType<ExpressionVariableModel>( "org.qfield", 1, 0, "ExpressionVariableModel" ); | |||
| qmlRegisterType<ExternalStorage>( "org.qfield", 1, 0, "ExternalStorage" ); | |||
There was a problem hiding this comment.
Can we refactor the module identifier and version into variables to improve maintainability and avoid duplication?
Suggested implementation:
const char* QML_MODULE_NAME = "org.qfield";
const int QML_MODULE_MAJOR_VERSION = 1;
const int QML_MODULE_MINOR_VERSION = 0;This will allow for easier updates to the module identifier and version in the future, ensuring consistency across the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a fetch-only (i.e. read-only) support for external storage-driven attachment editor widget, i.e. when a given attribute's editor widget is configured like this in QGIS:
This is a nice step towards on-demand content for attachments, and increase our (already quite high) attribute form interoperability between QField and QGIS.