Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check for email uniqueness if the email is not populated #1028

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Do not check for email uniqueness if the email is not populated #1028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions docker-app/qfieldcloud/core/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,15 +362,16 @@ class Meta:
verbose_name_plural = "people"

def clean(self):
person_qs = self.__class__.objects.filter(email__iexact=self.email)
if self.email:
person_qs = self.__class__.objects.filter(email__iexact=self.email)

if self.pk:
person_qs = person_qs.exclude(pk=self.pk)
if self.pk:
person_qs = person_qs.exclude(pk=self.pk)

if person_qs.exists():
raise ValidationError(
_("This email is already taken by another user!").format(self.email)
)
if person_qs.exists():
raise ValidationError(
_("This email is already taken by another user!").format(self.email)
)

return super().clean()

Expand Down
Loading