Merge by form factor #24
Open
+457
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domi4484
force-pushed
the
merge-by-form-factor
branch
2 times, most recently
from
64a53d5 to
abe6204
Compare
domi4484
force-pushed
the
merge-by-form-factor
branch
from
abe6204 to
3182c33
Compare
gacarrillor
approved these changes
Apr 4, 2025
| action = self.create_action("help.png", "Aiuto", self.do_help) | ||
| self.toolbar.addAction(action) | ||
| self.iface.addPluginToMenu(PLUGIN_NAME, action) | ||
| settings_action = self.create_action("gear.png", "Ipostazioni", self.do_settings) |
There was a problem hiding this comment.
Italian typo 😛
(My level of Italian has suddenly increased by 0.0000001%)
| @@ -61,6 +63,17 @@ def initAlgorithm(self, config=None): | |||
| ) | |||
| ) | |||
|
|
|||
| self.addParameter( | |||
| QgsProcessingParameterField( | |||
There was a problem hiding this comment.
Is the value coming from a vector layer field or could we use QgsProcessingParameterNumber instead?
| inLayer = self.parameterAsSource(parameters, self.INPUT, context) | ||
| mode = self.parameterAsEnum(parameters, self.MODE, context) | ||
| formFactor = self.parameterAsDouble(parameters, self.FORM_FACTOR, context) | ||
| areaTreshold = self.parameterAsDouble(parameters, self.AREA_TRESHOLD, context) |
| if feedback.isCanceled(): | ||
| break | ||
|
|
||
| print("Error: could not merge feature: {}".format(feature.id())) |
There was a problem hiding this comment.
We should avoid prints in Processing algorithms, we could use the feedback object instead.
| def _checkArea(self, geometry, areaTreshold): | ||
| return geometry.area() <= areaTreshold | ||
|
|
||
| def _checkFormFactor(self, geometry, formFactorTreshold): |
|
|
||
| # End while | ||
| if not processLayer.commitChanges(): | ||
| raise QgsProcessingException(self.tr("Could not commit changes")) |
There was a problem hiding this comment.
I think we should call processLayer.rollBack() if we couldn't commit, specially because we'll use the dataProvider to add features in line 216, so we should have a clean layer buffer status before that line.
| OUTPUT = "OUTPUT" | ||
| MODE = "MODE" | ||
| FORM_FACTOR = "FORM_FACTOR" | ||
| AREA_TRESHOLD = "AREA_TRESHOLD" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add algorithm to merge elongated geometries under 10m² by form factor
Its disabled by default so Sergio can try it out and decide if activating or not