[meteofrance] New binding #15462

clinique · 2023-08-19T23:39:38Z

Resolves #15461 .

Data feed changed completely, this will have major impact on binding organization.

This binding also integrates another Meteo France service : rain previsions over the coming hour.

Being more generic, it has been renamed and meteoalerte binding should be removed.

openhab-bot · 2023-08-19T23:40:55Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/meteo-alerte-binding-do-not-receive-data-since-may-2023/148545/5

clinique · 2024-04-02T16:45:34Z

Ready to test : https://drive.google.com/file/d/10PtEt5kjDpJo84eNnsonbno83SEdWuOW/view?usp=drive_link

holgerfriedrich

@clinique I am not sure if I am a good reviewer for this binding.... For now, I just checked a few code style topics, javadoc has only expected warnings, i18n property file is in sync. That is what I can do today.
Find my suggestions below.

...hab.binding.meteoalerte/src/main/java/org/openhab/binding/meteoalerte/internal/dto/Term.java

...binding.meteoalerte/src/main/java/org/openhab/binding/meteoalerte/internal/dto/BlocType.java

...lerte/src/main/java/org/openhab/binding/meteoalerte/internal/handler/MeteoAlerteHandler.java

...teoalerte/src/main/java/org/openhab/binding/meteoalerte/internal/db/DepartmentDbService.java

clinique · 2024-04-02T23:22:59Z

@lolodomo : if you can start to have a look at this. I think it's pretty ready codewise. Documentation still has to be updated.

clinique · 2024-04-22T22:52:04Z

@lolodomo : can I kindly request a review ?

holgerfriedrich

just 2 minor comments regarding the README...

bundles/org.openhab.binding.meteoalerte/README.md

holgerfriedrich

Sorry, this one seems missing.
Otherwise the parts I have looked at LGTM, leaving the code review to @lolodomo.

holgerfriedrich · 2024-04-24T05:43:00Z

bundles/org.openhab.binding.meteoalerte/README.md

+| apikey    | Data-platform token to access the service. Mandatory. |
+
+To obtain an API key, you must create an account on https://portail-api.meteofrance.fr/web/fr/
+Inside the Portail API, create an application on "Bulletin Vigilance" and generate they API Key (set duration to 0).


Suggested change

Inside the Portail API, create an application on "Bulletin Vigilance" and generate they API Key (set duration to 0).

Inside the Portail API, create an application on "Bulletin Vigilance" and generate they API key (set duration to 0).

clinique · 2024-05-19T18:48:27Z

@lolodomo : as you're currently working only for me 😀 , maybe you can have a look at this one also ?

lolodomo · 2024-05-19T20:16:06Z

@lolodomo : as you're currently working only for me 😀 , maybe you can have a look at this one also ?

I hope you appreciate :)
That is not fully true, I am also working for @mherwege , my top priority regarding reviews ;)

Signed-off-by: clinique <[email protected]>

Small and slow progress Signed-off-by: clinique <[email protected]> Signed-off-by: [email protected] <[email protected]>

Data is ok. Still has to take care of auto refresh and we're ready to go. Signed-off-by: clinique <[email protected]>

Signed-off-by: clinique <[email protected]>

Signed-off-by: [email protected] <[email protected]>

Signed-off-by: clinique <[email protected]>

Switching internal dept Id from string name of the department to department number. Signed-off-by: [email protected] <[email protected]>

Signed-off-by: [email protected] <[email protected]>

Signed-off-by: clinique <[email protected]>

Signed-off-by: Gaël L'hopital <[email protected]>

Renamed from Meteo Alerte to Meteo France Signed-off-by: Gaël L'hopital <[email protected]>

Signed-off-by: Gaël L'hopital <[email protected]>

lsiepel

Thanks for reviving this binding. As @lolodomo has chosen to work for anotther contributer ;-) i took the change and reviewed this PR.
Covered all files and after this initial round i expect jus a smaller last round before a merge. Ping me when you are ready to proceed.

bom/openhab-addons/pom.xml

lsiepel · 2024-09-19T19:21:46Z

bundles/org.openhab.binding.meteofrance/README.md


-The Meteo Alerte binding gives alert level regarding major weather related risk factors.
+The Meteo France binding gives alert level regarding major weather related risk factors as well as rain intensity forecasts.
 This binding provides its own icon set and provides appropriate static and dynamic SVG icons (see items examples below).



A section with the supported Things is missing. When added, it really helps to get a quick overisght of the bindings basics.

Rearranged the section.

lsiepel · 2024-09-19T19:22:55Z

bundles/org.openhab.binding.meteofrance/README.md

+| apikey    | Data-platform token to access the service. Mandatory. |
+
+To obtain an API key, you must create an account on https://portail-api.meteofrance.fr/web/fr/
+Inside the Portail API, create an application on "Bulletin Vigilance" and generate they API Key (set duration to 0).


Suggested change

Inside the Portail API, create an application on "Bulletin Vigilance" and generate they API Key (set duration to 0).

Inside the API Portal, create an application on "Bulletin Vigilance" and generate they API Key (set duration to 0).

lsiepel · 2024-09-19T19:24:38Z

bundles/org.openhab.binding.meteofrance/README.md


 ## Thing Configuration

-The thing has a few configuration parameters:
+The `vigilance` thing has these configuration parameters:


i could not get a clear meaning of vigilance why did you choose this name as thing id?

This is the name coming from the source dataset - let me see if I can find a better naming.

lsiepel · 2024-09-19T19:26:00Z

bundles/org.openhab.binding.meteofrance/README.md

+| oh:meteofrance:vent             |   Yes   | ![](src/main/resources/icon/vent.svg) |
+| oh:meteofrance:pluie-inondation |   Yes   | ![](src/main/resources/icon/pluie-inondation.svg) |
+| oh:meteofrance:orage            |   Yes   | ![](src/main/resources/icon/orage.svg) |
+| oh:meteofrance:inondation       |   Yes   | ![](src/main/resources/icon/inondation.svg) |
+| oh:meteofrance:neige            |   Yes   | ![](src/main/resources/icon/neige.svg) |
+| oh:meteofrance:canicule         |   Yes   | ![](src/main/resources/icon/canicule.svg) |
+| oh:meteofrance:grand-froid      |   Yes   | ![](src/main/resources/icon/grand-froid.svg) |
+| oh:meteofrance:avalanches       |   Yes   | ![](src/main/resources/icon/avalanches.svg) |
+| oh:meteofrance:vague-submersion |   Yes   | ![](src/main/resources/icon/vague-submersion.svg) |
+| oh:meteofrance:meteo_france     |   No    | ![](src/main/resources/icon/meteo_france.svg) |


To make the icons viewable in the docs, you have to copy the files to the docs folder and alter these links.
Unoftunately that means these icons are doubled in the repository.

Duplicated images in doc/images. Added the intensity icon.

lsiepel · 2024-09-19T20:05:12Z

.../src/main/java/org/openhab/binding/meteofrance/internal/handler/MeteoFranceChildHandler.java

+            BridgeHandler handler = bridge.getHandler();
+            if (handler instanceof MeteoFranceBridgeHandler maHandler) {


Suggested change

BridgeHandler handler = bridge.getHandler();

if (handler instanceof MeteoFranceBridgeHandler maHandler) {

if (bridge.getHandler() instanceof MeteoFranceBridgeHandler maHandler) {

lsiepel · 2024-09-19T20:07:49Z

...ance/src/main/java/org/openhab/binding/meteofrance/internal/handler/RainForecastHandler.java

+
+        updateStatus(ThingStatus.UNKNOWN);
+
+        ForecastConfiguration config = getConfigAs(ForecastConfiguration.class);


No need to check the configuration ? For like isBlank() or for having a numeric value? (i assumed the department code are all numeric ?)
and set the thing state to CONFIGURATION_ERROR accordingly?

location should be a valid PointType. Modified accordingly.

lsiepel · 2024-09-19T20:12:33Z

...ance/src/main/java/org/openhab/binding/meteofrance/internal/handler/RainForecastHandler.java

+
+    private void updateDate(String channelId, @Nullable ZonedDateTime zonedDateTime) {
+        if (isLinked(channelId)) {
+            updateState(channelId, zonedDateTime != null ? new DateTimeType(zonedDateTime) : UnDefType.NULL);


AFAIK the framework does not automatically change the zoneddatetime to the configured timezone of openHAB.
Not sure in what timezone the API responds, but it would be nice to use the openHAB api -> timezoneprovider to update it to the openHAB configured timezone.

You're more than right.

lsiepel · 2024-09-19T20:15:53Z

...ofrance/src/main/java/org/openhab/binding/meteofrance/internal/handler/VigilanceHandler.java

+                }
+                updateStatus(ThingStatus.ONLINE);
+            } else {
+                updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.NONE, "No data available for the department");


Just a check, what would be the cause of no data being available?

I guess that I has happened during tests or developments if it is there.

lsiepel · 2024-09-19T20:17:48Z

...ofrance/src/main/java/org/openhab/binding/meteofrance/internal/handler/VigilanceHandler.java

+
+    private void updateDate(String channelId, ZonedDateTime zonedDateTime) {
+        if (isLinked(channelId)) {
+            updateState(channelId, new DateTimeType(zonedDateTime));


See earlier comment about respecting the openHAB configured timezone with the TimeZoneProvider

Signed-off-by: Gaël L'hopital <[email protected]>

clinique added bug An unexpected problem or unintended behavior of an add-on work in progress A PR that is not yet ready to be merged labels Aug 19, 2023

clinique self-assigned this Aug 19, 2023

clinique force-pushed the meteoalerte_new_feed branch from bb043b9 to cdea557 Compare March 29, 2024 15:46

clinique removed the work in progress A PR that is not yet ready to be merged label Apr 2, 2024

clinique requested a review from holgerfriedrich April 2, 2024 16:39

holgerfriedrich reviewed Apr 2, 2024

View reviewed changes

clinique requested review from lolodomo and jlaur April 2, 2024 23:23

clinique changed the title ~~[meteoalerte] Adapting binding to new data feed~~ [meteoalerte] Resurrect the binding Apr 3, 2024

clinique requested a review from holgerfriedrich April 22, 2024 22:51

holgerfriedrich reviewed Apr 23, 2024

View reviewed changes

bundles/org.openhab.binding.meteoalerte/README.md Outdated Show resolved Hide resolved

bundles/org.openhab.binding.meteoalerte/README.md Outdated Show resolved Hide resolved

clinique requested a review from holgerfriedrich April 23, 2024 22:58

holgerfriedrich reviewed Apr 24, 2024

View reviewed changes

clinique force-pushed the meteoalerte_new_feed branch from a2fb986 to 5007393 Compare May 28, 2024 15:03

clinique force-pushed the meteoalerte_new_feed branch from 5007393 to 2cc4b74 Compare June 24, 2024 08:21

clinique requested a review from a team as a code owner June 25, 2024 10:12

clinique changed the title ~~[meteoalerte] Resurrect the binding~~ [meteofrance] New binding Jun 25, 2024

clinique added 6 commits August 20, 2024 15:35

Adapting binding to new data feed

e25343d

Signed-off-by: clinique <[email protected]>

Spotless apply was missing

db222ba

Signed-off-by: clinique <[email protected]>

Adapting binding to new data feed

dc02f9a

Small and slow progress Signed-off-by: clinique <[email protected]> Signed-off-by: [email protected] <[email protected]>

Department handler is now ok.

630db37

Data is ok. Still has to take care of auto refresh and we're ready to go. Signed-off-by: clinique <[email protected]>

Applied spotless

7bc9824

Signed-off-by: clinique <[email protected]>

Code review

d9ec9c0

Signed-off-by: clinique <[email protected]>

clinique added 17 commits August 20, 2024 15:35

Code review

259c343

Signed-off-by: clinique <[email protected]>

Code review 3

bc6d428

Signed-off-by: clinique <[email protected]>

Code review 4

dcd25d0

Signed-off-by: clinique <[email protected]>

Finalizing, ready for code review

d969ba2

Signed-off-by: [email protected] <[email protected]>

Apply spotless

e1e83f9

Signed-off-by: [email protected] <[email protected]>

Code review 5

8775078

Signed-off-by: clinique <[email protected]>

Fixing discovery service

3a8e004

Signed-off-by: clinique <[email protected]>

Fixing discovery.

340ab13

Switching internal dept Id from string name of the department to department number. Signed-off-by: [email protected] <[email protected]>

Updating documentation

a5d2809

Signed-off-by: [email protected] <[email protected]>

Code review #1

d5ad7af

Signed-off-by: clinique <[email protected]>

Enhancement - comments are not always provided

a2362b3

Signed-off-by: Gaël L'hopital <[email protected]>

Addition of next hour rain prevision

fb57f45

Signed-off-by: Gaël L'hopital <[email protected]>

Spotless and i18n

ac944ff

Signed-off-by: Gaël L'hopital <[email protected]>

Removed initial state of the intensity

b497267

Signed-off-by: Gaël L'hopital <[email protected]>

Renamed from Meteo Alerte to Meteo France

97d232a

Signed-off-by: Gaël L'hopital <[email protected]>

Switched to 4.3

217c264

Renamed from Meteo Alerte to Meteo France Signed-off-by: Gaël L'hopital <[email protected]>

Two small correction and rebased

68c6fec

Signed-off-by: Gaël L'hopital <[email protected]>

clinique force-pushed the meteoalerte_new_feed branch from dc17bf9 to 68c6fec Compare August 20, 2024 13:47

Pleasing SAT

62edd3f

Signed-off-by: Gaël L'hopital <[email protected]>

clinique added the enhancement An enhancement or new feature for an existing add-on label Aug 21, 2024

lsiepel requested changes Sep 19, 2024

View reviewed changes

Code review corrections

d7b8e31

Signed-off-by: Gaël L'hopital <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[meteofrance] New binding #15462

[meteofrance] New binding #15462

clinique commented Aug 19, 2023 •

edited

Loading

openhab-bot commented Aug 19, 2023

clinique commented Apr 2, 2024

holgerfriedrich left a comment

clinique commented Apr 2, 2024

clinique commented Apr 22, 2024

holgerfriedrich left a comment

holgerfriedrich left a comment

holgerfriedrich Apr 24, 2024

clinique commented May 19, 2024

lolodomo commented May 19, 2024

lsiepel left a comment

lsiepel Sep 19, 2024 •

edited

Loading

clinique Sep 20, 2024

lsiepel Sep 19, 2024

clinique Sep 20, 2024

lsiepel Sep 19, 2024 •

edited

Loading

clinique Sep 20, 2024

lsiepel Sep 19, 2024

clinique Sep 20, 2024 •

edited

Loading

lsiepel Sep 19, 2024

clinique Sep 20, 2024

lsiepel Sep 19, 2024

clinique Sep 20, 2024

lsiepel Sep 19, 2024

clinique Sep 20, 2024

lsiepel Sep 19, 2024

clinique Sep 20, 2024

lsiepel Sep 19, 2024

clinique Sep 20, 2024

	Inside the Portail API, create an application on "Bulletin Vigilance" and generate they API Key (set duration to 0).
	Inside the Portail API, create an application on "Bulletin Vigilance" and generate they API key (set duration to 0).

	Inside the Portail API, create an application on "Bulletin Vigilance" and generate they API Key (set duration to 0).
	Inside the API Portal, create an application on "Bulletin Vigilance" and generate they API Key (set duration to 0).

		BridgeHandler handler = bridge.getHandler();
		if (handler instanceof MeteoFranceBridgeHandler maHandler) {

	BridgeHandler handler = bridge.getHandler();
	if (handler instanceof MeteoFranceBridgeHandler maHandler) {
	if (bridge.getHandler() instanceof MeteoFranceBridgeHandler maHandler) {


		updateStatus(ThingStatus.UNKNOWN);

		ForecastConfiguration config = getConfigAs(ForecastConfiguration.class);

[meteofrance] New binding #15462

Are you sure you want to change the base?

[meteofrance] New binding #15462

Conversation

clinique commented Aug 19, 2023 • edited Loading

openhab-bot commented Aug 19, 2023

clinique commented Apr 2, 2024

holgerfriedrich left a comment

Choose a reason for hiding this comment

clinique commented Apr 2, 2024

clinique commented Apr 22, 2024

holgerfriedrich left a comment

Choose a reason for hiding this comment

holgerfriedrich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clinique commented May 19, 2024

lolodomo commented May 19, 2024

lsiepel left a comment

Choose a reason for hiding this comment

lsiepel Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsiepel Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clinique Sep 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clinique commented Aug 19, 2023 •

edited

Loading

lsiepel Sep 19, 2024 •

edited

Loading

lsiepel Sep 19, 2024 •

edited

Loading

clinique Sep 20, 2024 •

edited

Loading