-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autoUpdatePolicy for write-only channels #17439
Conversation
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
As this PR changes the behaviour, this should be listed in the release notes. Therefore it would be berst to split the PR into seperate PR's per binding. wdyt?
I can go either way... It is such a minor change to have the autoUpdate policy implicitly set for these stateless channels that I thought I would try to do them all in one PR rather than all the noise that 9 individual PRs would cause. |
@openhab/add-ons-maintainers wdyt? |
@lsiepel Would we consider it a breaking change? If so, we would have it in the distro's update.lst file, which would automatically warn the users. |
OK, I will create individual PRs instead. |
I would not consider this a breaking change |
Correct the autoUpdatePolicy for all of the write-only channels in bindings for which I am the code owner.