Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameter nullability #566

Closed
wants to merge 1 commit into from
Closed

Update parameter nullability #566

wants to merge 1 commit into from

Conversation

davedelong
Copy link

Fixes #565

@codecov-commenter
Copy link

Codecov Report

Merging #566 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   72.77%   72.77%           
=======================================
  Files          33       33           
  Lines        2490     2490           
=======================================
  Hits         1812     1812           
  Misses        678      678           
Impacted Files Coverage Δ
Source/AppAuthCore/OIDEndSessionRequest.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7232d6e...e1d78da. Read the comment docs.

@markusfassbender
Copy link

markusfassbender commented Nov 23, 2020

Thanks davedelong, it would be great to see this merged!

@petea petea self-requested a review March 16, 2022 18:10
Copy link
Collaborator

@petea petea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davedelong could you update the nullability annotations for the initializer implementations as well?

@philet
Copy link

philet commented Apr 7, 2022

@davedelong could you update the nullability annotations for the initializer implementations as well?

@davedelong If you give me access to the branch for this pull request I could do this update. (I'd be glad to get this pull request merged too.)

@davedelong
Copy link
Author

@petea @philet I'm not using this project anymore and am intending to delete my fork just to keep my personal GitHub tidy. You're welcome to copy the diff and re-apply it. All I did was add 5 nullability annotations.

@petea petea added this to the 2.0.0 milestone Apr 7, 2022
@philet
Copy link

philet commented Apr 8, 2022

@davedelong @petea Ok. I created a new pull request for this issue: #702

@davedelong davedelong closed this by deleting the head repository Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDEndSessionRequest initializers lack correct nullability specifiers
5 participants