Skip to content

feat: xlsm support #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cs50victor merged 2 commits into from
Mar 24, 2026
Merged

feat: xlsm support #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b505ea8
feat: add xlsm extension to spreadsheet document type detection
cs50victor Mar 24, 2026
bd4aab2
test: add xlsm test fixture and coverage for save and logo-header tests
cs50victor Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .github/assets/simple.xlsm
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion __tests__/logo-header.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function assertFilesExist(files) {
}

function getDocType(ext) {
if (['xlsx', 'xls', 'ods', 'csv'].includes(ext)) return 'cell';
if (['xlsx', 'xls', 'xlsm', 'ods', 'csv'].includes(ext)) return 'cell';
if (['docx', 'doc', 'odt', 'txt', 'rtf', 'html'].includes(ext)) return 'word';
if (['pptx', 'ppt', 'odp'].includes(ext)) return 'slide';
return 'slide';
Expand Down
4 changes: 4 additions & 0 deletions __tests__/save.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,8 @@ describe('CSV save round-trip', () => {
test('should save hard.csv', async () => {
await convertAndSave('hard.csv');
}, 60_000);

test('should save simple.xlsm', async () => {
await convertAndSave('simple.xlsm');
});
});
2 changes: 1 addition & 1 deletion server-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function generateFileHash(filepath) {
*/
function getDocTypeFromFilename(filename) {
const ext = filename.split('.').pop().toLowerCase();
if (ext === 'xlsx' || ext === 'xls' || ext === 'ods' || ext === 'csv') {
if (ext === 'xlsx' || ext === 'xls' || ext === 'xlsm' || ext === 'ods' || ext === 'csv') {
return 'cell';
} else if (ext === 'docx' || ext === 'doc' || ext === 'odt' || ext === 'txt' || ext === 'rtf' || ext === 'html') {
return 'word';
Expand Down
2 changes: 1 addition & 1 deletion test/batch-files.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
.github/assets/simple.ppt
.github/assets/simple.csv
.github/assets/hard.csv

.github/assets/simple.xlsm
1 change: 1 addition & 0 deletions test/logo-files.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
.github/assets/medium.ppt
.github/assets/simple.ppt
.github/assets/simple.csv
.github/assets/simple.xlsm
Loading