Skip to content

Conversation

rbrchen
Copy link
Contributor

@rbrchen rbrchen commented Sep 4, 2025

Add a tool to tag kernel buffers with RO, WO, RW, or NA.

Currently, the result of the buffer tagger is only used to assert that it matches with the respective buffer annotations in the HAT kernels.

Also make moduleOp an opt-out backend for HAT, which can be disabled by passing the flag noModuleOp when running HAT. For example, running the mandel example with the ffi-opencl backend and moduleOp disabled can be done with

java @hat/run noModuleOp ffi-opencl mandel

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/548/head:pull/548
$ git checkout pull/548

Update a local copy of the PR:
$ git checkout pull/548
$ git pull https://git.openjdk.org/babylon.git pull/548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 548

View PR using the GUI difftool:
$ git pr show -t 548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/548.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2025

👋 Welcome back rbrchen! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 4, 2025

@rbrchen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Add buffer tagging and opt-out moduleOp backend

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@rbrchen rbrchen marked this pull request as ready for review September 5, 2025 21:12
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2025

Webrevs

@rbrchen
Copy link
Contributor Author

rbrchen commented Sep 8, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 8, 2025
@openjdk
Copy link

openjdk bot commented Sep 8, 2025

@rbrchen
Your change (at version 75e5fc3) is now ready to be sponsored by a Committer.

@grfrost
Copy link
Collaborator

grfrost commented Sep 8, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 8, 2025

Going to push as commit 4cd871e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 8, 2025
@openjdk openjdk bot closed this Sep 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 8, 2025
@openjdk
Copy link

openjdk bot commented Sep 8, 2025

@grfrost @rbrchen Pushed as commit 4cd871e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants