-
Notifications
You must be signed in to change notification settings - Fork 31
Add buffer tagging and opt-out moduleOp backend #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back rbrchen! A progress list of the required criteria for merging this PR into |
@rbrchen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 4cd871e. |
Add a tool to tag kernel buffers with RO, WO, RW, or NA.
Currently, the result of the buffer tagger is only used to assert that it matches with the respective buffer annotations in the HAT kernels.
Also make moduleOp an opt-out backend for HAT, which can be disabled by passing the flag
noModuleOp
when running HAT. For example, running the mandel example with the ffi-opencl backend and moduleOp disabled can be done withProgress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/548/head:pull/548
$ git checkout pull/548
Update a local copy of the PR:
$ git checkout pull/548
$ git pull https://git.openjdk.org/babylon.git pull/548/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 548
View PR using the GUI difftool:
$ git pr show -t 548
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/548.diff
Using Webrev
Link to Webrev Comment