-
Notifications
You must be signed in to change notification settings - Fork 41
8371549: [CRaC] Implement C/R in Selector on non-Linux #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: crac
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into |
|
@rvansa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Historically we have an extensive set of tests for java.nio.channels.Selector. However this runs only on Linux (using CRIU) rather than being platform agnostic and tested on all platforms. On Linux, it does not exercise PollSelectorImpl (this can be preferred using a system property) either - just the default EpollSelectorImpl.
This PR enables testing on all available Selector implementations, cleans up the implementation of those tests and introduces the C/R implementations.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/276/head:pull/276$ git checkout pull/276Update a local copy of the PR:
$ git checkout pull/276$ git pull https://git.openjdk.org/crac.git pull/276/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 276View PR using the GUI difftool:
$ git pr show -t 276Using diff file
Download this PR as a diff file:
https://git.openjdk.org/crac/pull/276.diff
Using Webrev
Link to Webrev Comment