8345500: Timeout in jdk.jfr.api.consumer.streaming.TestJVMCrash

[gerard-ziemski]

In this fix we add 1 second delay after we create a process.

On macOS we seem to be creating a process so quickly, that other threads need time to see it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345500: Timeout in jdk.jfr.api.consumer.streaming.TestJVMCrash (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23163/head:pull/23163
$ git checkout pull/23163

Update a local copy of the PR:
$ git checkout pull/23163
$ git pull https://git.openjdk.org/jdk.git pull/23163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23163

View PR using the GUI difftool:
$ git pr show -t 23163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23163.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@gerard-ziemski The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8f8f267c)

[egahlin]

I don't think this is the correct way to fix the issue. Users may write code that doesn't wait 1 s and run into the same problem. Why shouldn't a client be able to poll repeatedly? Also, it's only a matter of time before it happens again, either because the hardware is slow or because the processes are starved due to other things running on the machine.

[gerard-ziemski]

I don't think this is the correct way to fix the issue. Users may write code that doesn't wait 1 s and run into the same problem. Why shouldn't a client be able to poll repeatedly? Also, it's only a matter of time before it happens again, either because the hardware is slow or because the processes are starved due to other things running on the machine.

To be honest I'm not 100% happy with the fix, it was just the simplest one that I could think of. Let me look into it a bit more.