Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347958: Minor compiler cleanups relating to MandatoryWarningHandler #23167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Jan 16, 2025

After recent improvements to Lint-related classes, there are now a few minor cleanup opportunities relating to MandatoryWarningHandler.

  1. The new LintWarning class provides access to the associated LintCategory. This means that the LintCategory parameter being passed to the MandatoryWarningHandler constructor is no longer needed.
  2. The prefix string being passed to the MandatoryWarningHandler constructor can (in most cases) be inferred as well.
  3. The field Check.sunApiHandler (which has type MandatoryWarningHandler) is no longer used and can be removed.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347958: Minor compiler cleanups relating to MandatoryWarningHandler (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23167/head:pull/23167
$ git checkout pull/23167

Update a local copy of the PR:
$ git checkout pull/23167
$ git pull https://git.openjdk.org/jdk.git pull/23167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23167

View PR using the GUI difftool:
$ git pr show -t 23167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23167.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2025

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 16, 2025
@openjdk
Copy link

openjdk bot commented Jan 16, 2025

@archiecobbs The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 16, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant