8347958: Minor compiler cleanups relating to MandatoryWarningHandler #23167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent improvements to Lint-related classes, there are now a few minor cleanup opportunities relating to
MandatoryWarningHandler
.LintWarning
class provides access to the associatedLintCategory
. This means that theLintCategory
parameter being passed to theMandatoryWarningHandler
constructor is no longer needed.prefix
string being passed to theMandatoryWarningHandler
constructor can (in most cases) be inferred as well.Check.sunApiHandler
(which has typeMandatoryWarningHandler
) is no longer used and can be removed.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23167/head:pull/23167
$ git checkout pull/23167
Update a local copy of the PR:
$ git checkout pull/23167
$ git pull https://git.openjdk.org/jdk.git pull/23167/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23167
View PR using the GUI difftool:
$ git pr show -t 23167
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23167.diff
Using Webrev
Link to Webrev Comment