Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with link time optimization (lto) , configure flag is --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of errors.
One workaround is just to configure without gtest ; this one changes the make to NOT use the lto build flags for gtest , just for the "normal" libjvm.so .
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23173/head:pull/23173
$ git checkout pull/23173
Update a local copy of the PR:
$ git checkout pull/23173
$ git pull https://git.openjdk.org/jdk.git pull/23173/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23173
View PR using the GUI difftool:
$ git pr show -t 23173
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23173.diff
Using Webrev
Link to Webrev Comment