Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347763: [doc] Add documentation of module options for JEP 483 #23189

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Jan 18, 2025

Hi all,

This pull request contains a backport of commit 17e3df65 from the openjdk/jdk repository.

The commit being backported was authored by Calvin Cheung on 17 Jan 2025 and was reviewed by Ioi Lam.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347763: [doc] Add documentation of module options for JEP 483 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23189/head:pull/23189
$ git checkout pull/23189

Update a local copy of the PR:
$ git checkout pull/23189
$ git pull https://git.openjdk.org/jdk.git pull/23189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23189

View PR using the GUI difftool:
$ git pr show -t 23189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23189.diff

Using Webrev

Link to Webrev Comment

@calvinccheung calvinccheung marked this pull request as ready for review January 18, 2025 00:42
@calvinccheung
Copy link
Member Author

/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2025

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 18, 2025

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347763: [doc] Add documentation of module options for JEP 483

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk24 branch:

  • febcfd6: 8345750: Shenandoah: Test TestJcmdHeapDump.java#aggressive intermittent assert(gc_cause() == GCCause::_no_gc) failed: Over-writing cause

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 17e3df652feb2a0fb960cd235c0efc4b482731d6 8347763: [doc] Add documentation of module options for JEP 483 Jan 18, 2025
@openjdk
Copy link

openjdk bot commented Jan 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 18, 2025

@calvinccheung
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 18, 2025

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 22, 2025
@calvinccheung
Copy link
Member Author

Thanks @iklam.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 22, 2025

Going to push as commit bc19494.
Since your change was applied there has been 1 commit pushed to the jdk24 branch:

  • febcfd6: 8345750: Shenandoah: Test TestJcmdHeapDump.java#aggressive intermittent assert(gc_cause() == GCCause::_no_gc) failed: Over-writing cause

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 22, 2025
@openjdk openjdk bot closed this Jan 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 22, 2025
@openjdk
Copy link

openjdk bot commented Jan 22, 2025

@calvinccheung Pushed as commit bc19494.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants