-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347763: [doc] Add documentation of module options for JEP 483 #23189
8347763: [doc] Add documentation of module options for JEP 483 #23189
Conversation
/label add hotspot-runtime |
👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into |
@calvinccheung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@calvinccheung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @iklam. /integrate |
Going to push as commit bc19494.
Your commit was automatically rebased without conflicts. |
@calvinccheung Pushed as commit bc19494. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 17e3df65 from the openjdk/jdk repository.
The commit being backported was authored by Calvin Cheung on 17 Jan 2025 and was reviewed by Ioi Lam.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23189/head:pull/23189
$ git checkout pull/23189
Update a local copy of the PR:
$ git checkout pull/23189
$ git pull https://git.openjdk.org/jdk.git pull/23189/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23189
View PR using the GUI difftool:
$ git pr show -t 23189
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23189.diff
Using Webrev
Link to Webrev Comment