8304674: File java.c compile error with -fsanitize=address -O0

[sendaoYan]

Hi all,
File src/java.base/share/native/libjli/java.c compile error: control reaches end of non-void function [-Werror=return-type] with gcc options -fsanitize=address -O0. The function int JavaMain(void* _args) in this file will execute return ret in LEAVE() macro, but gcc with -O0 is not smart enough to recognized that the function already has return statement before at the end of function. It's a gcc bug which has been recorded by 80959, and below code snippet can demonstrate the gcc bug. I think we should disable return-type gcc warning for java.c file before the gcc bug has been fixed. Risk is low.

> cat java.c
char a() {
  return 0;
  int b;
  if (a(&b))
    return 0;
}

> gcc -O0 -Wall -Wextra -Werror -O0 -c java.c -fsanitize=address
java.c: In function ‘a’:
java.c:6:1: error: control reaches end of non-void function [-Werror=return-type]
    6 | }
      | ^
cc1: all warnings being treated as errors

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8304674: File java.c compile error with -fsanitize=address -O0 (Bug - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24318/head:pull/24318
$ git checkout pull/24318

Update a local copy of the PR:
$ git checkout pull/24318
$ git pull https://git.openjdk.org/jdk.git pull/24318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24318

View PR using the GUI difftool:
$ git pr show -t 24318

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24318.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304674: File java.c compile error with -fsanitize=address -O0

Reviewed-by: ihse, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• d358f5f: 8347449: C2: UseLoopPredicate off should also turn UseProfiledLoopPredicate off
• f301663: 8352893: C2: OrL/INode::add_ring optimize (x | -1) to -1
• 15d36ee: 8353330: Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier
• e6fe249: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"
• 096e70d: 8352437: Support --add-exports with -XX:+AOTClassLinking
• 6970cf6: 8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC
• afcad8c: 5043343: FileImageInputStream and FileImageOutputStream do not properly track streamPos for RandomAccessFile
• 6891490: 8353324: Clean up of comments and import after 8319192
• 07fd666: 8342984: Bump minimum boot jdk to JDK 24
• 6a46d55: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132
• ... and 39 more: https://git.openjdk.org/jdk/compare/8cbadf78d04d0e3d1136a5582f281de099fc5e49...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (8d929c8d)
• 01: Full - Incremental (83beb975)
• 00: Full (78785e27)

[magicus]

While I normally advocate using DISABLE_WARNING in makefiles instead of pragmas, in this particular case I wonder if not a pragma in the LEAVE macro would be better?

[sendaoYan]

in this particular case I wonder if not a pragma in the LEAVE macro would be better?

Thanks, I will try it later.

[sendaoYan]

While I normally advocate using DISABLE_WARNING in makefiles instead of pragmas, in this particular case I wonder if not a pragma in the LEAVE macro would be better?

PR has been changed to use #pragma GCC diagnostic ignored "-Wreturn-type" instead of used DISABLE_WARNING in makefile. Change has been verified locally. The pragma shoule place at the end of function } could work normally.

[magicus]

LGTM.

/reviewers 2

[openjdk]

@magicus
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[TheShermanTanker]

I was going to suggest adding an && condition checking for ! __clang__ in the #if, but after some thinking I think it is not worth the trouble to add that. This looks good to go

[sendaoYan]

Thanks for the reviews @magicus @TheShermanTanker

/integrate

[openjdk]

Going to push as commit 9076673.
Since your change was applied there have been 50 commits pushed to the master branch:

• 8fb67ac: 8282053: IGV: refine schedule approximation
• d358f5f: 8347449: C2: UseLoopPredicate off should also turn UseProfiledLoopPredicate off
• f301663: 8352893: C2: OrL/INode::add_ring optimize (x | -1) to -1
• 15d36ee: 8353330: Test runtime/cds/appcds/SignedJar.java fails in CDSHeapVerifier
• e6fe249: 8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"
• 096e70d: 8352437: Support --add-exports with -XX:+AOTClassLinking
• 6970cf6: 8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC
• afcad8c: 5043343: FileImageInputStream and FileImageOutputStream do not properly track streamPos for RandomAccessFile
• 6891490: 8353324: Clean up of comments and import after 8319192
• 07fd666: 8342984: Bump minimum boot jdk to JDK 24
• ... and 40 more: https://git.openjdk.org/jdk/compare/8cbadf78d04d0e3d1136a5582f281de099fc5e49...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 9076673.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.