8359383: Incorrect starting positions for implicitly typed variables

[archiecobbs]

This fixes starting position bugs relating to implicitly typed variables; see the linked issue for details.

This also makes it possible to recover the declaration type (explicit, implicit, or var) from a JCVariableDecl and, in the case of var declarations, the starting position of the var; previously this wasn't possible.

Finally, as a minor drive-by improvement, we can now pretty print var as var instead of /*missing*/.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359383: Incorrect starting positions for implicitly typed variables (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25786/head:pull/25786
$ git checkout pull/25786

Update a local copy of the PR:
$ git checkout pull/25786
$ git pull https://git.openjdk.org/jdk.git pull/25786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25786

View PR using the GUI difftool:
$ git pr show -t 25786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25786.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1272b52d)