8359707: Add classfile modification code to RedefineClassHelper

[coleenp]

I copied this code for another test in the Valhalla repo and thought it would be a good utility function. It might be better written using the Classfile API.
Tested with test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359707: Add classfile modification code to RedefineClassHelper (Enhancement - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25857/head:pull/25857
$ git checkout pull/25857

Update a local copy of the PR:
$ git checkout pull/25857
$ git pull https://git.openjdk.org/jdk.git pull/25857/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25857

View PR using the GUI difftool:
$ git pr show -t 25857

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25857.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359707: Add classfile modification code to RedefineClassHelper

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• d627282: 8360143: ProblemList runtime/NMT/VirtualAllocTestType.java
• 96f71a9: 8255082: HotSpot Style Guide should permit noexcept
• 17cf497: 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed
• ... and 67 more: https://git.openjdk.org/jdk/compare/b3f56086c99023a30b91f90c2acbed51b3b17ec0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[coleenp]

/label add hotspot-runtime

[openjdk]

@coleenp
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (6bc1ca59)
• 00: Full (3654034f)

[sspitsyn]

This looks reasonable. I've posted one nit suggestion.

[sspitsyn]

Nit: I'd suggest to rename parameters:
oldString => oldClassName
newString => newClassName

Alternatively, it is possible to pass bytecodes buffer instead of class loader and keep oldString and newString as before.

[coleenp]

I wanted this code to also read bytecodes off the disk and not the caller do that either. The code for getBytecodes or very similar is duplicated all over the tests also.

[coleenp]

I can add a byte buffer version though.

[sspitsyn]

Thank you for the update! Looks good.

[lmesnik]

I think this should be
try(InputStream is = loader.getResourceAsStream(name + ".class");) {
...