Skip to content

8357739: [jittester] disable the hashCode method #25859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lepestock
Copy link
Contributor

@lepestock lepestock commented Jun 17, 2025

JITTester often uses the hasCode method (in fact, in almost every generated test). Given that the method can be unstable between runs or in interpreted vs compiled runs, it can create false-positives.

This PR fixes the issue by adding support for method templates similar to the ones used in CompilerCommands). All of those exclude templates match (and exclude) String.indexOf(String), for example:

java/lang/::*(Ljava/lang/String;I)
*String::indexOf(*)
java/lang/*::indexOf

Additionally, the PR adds support for comments (starting from '#') and empty lines in the excludes file.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357739: [jittester] disable the hashCode method (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25859/head:pull/25859
$ git checkout pull/25859

Update a local copy of the PR:
$ git checkout pull/25859
$ git pull https://git.openjdk.org/jdk.git pull/25859/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25859

View PR using the GUI difftool:
$ git pr show -t 25859

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25859.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@lepestock The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@lepestock lepestock changed the title Jittester/disable hashcode method/jdk 8357739/pub 8357739: [jittester] disable the hashCode method Jun 18, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

@AlanBateman
Copy link
Contributor

/label remove core-libs

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@AlanBateman
The core-libs label was successfully removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants