8357739: [jittester] disable the hashCode method #25859
Open
+435
−154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JITTester often uses the
hasCode
method (in fact, in almost every generated test). Given that the method can be unstable between runs or in interpreted vs compiled runs, it can create false-positives.This PR fixes the issue by adding support for method templates similar to the ones used in CompilerCommands). All of those exclude templates match (and exclude)
String.indexOf(String)
, for example:Additionally, the PR adds support for comments (starting from '#') and empty lines in the excludes file.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25859/head:pull/25859
$ git checkout pull/25859
Update a local copy of the PR:
$ git checkout pull/25859
$ git pull https://git.openjdk.org/jdk.git pull/25859/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25859
View PR using the GUI difftool:
$ git pr show -t 25859
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25859.diff
Using Webrev
Link to Webrev Comment