-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8359895: JFR: method-timing view doesn't work #25869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into |
@egahlin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 984d7f9.
Your commit was automatically rebased without conflicts. |
/backport :jdk25 |
@egahlin the backport was successfully created on the branch backport-egahlin-984d7f9c-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:
|
Could I have review of PR that fixes the method timing view.
Testing: jdk/jdk/jfr
Thanks
Erik
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25869/head:pull/25869
$ git checkout pull/25869
Update a local copy of the PR:
$ git checkout pull/25869
$ git pull https://git.openjdk.org/jdk.git pull/25869/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25869
View PR using the GUI difftool:
$ git pr show -t 25869
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25869.diff
Using Webrev
Link to Webrev Comment