-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8359959: Test runtime/NMT/VirtualAllocTestType.java failed: '\\[0x[0]*7f7dc4043000 - 0x[0]*7f7dc4083000\\] reserved 256KB for Test' missing from stdout/stderr #25894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…*7f7dc4043000 - 0x[0]*7f7dc4083000\\] reserved 256KB for Test' missing from stdout/stderr
👋 Welcome back azafari! A progress list of the required criteria for merging this PR into |
@afshin-zafari This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@afshin-zafari The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
wb.NMTReleaseMemory(addr1, reserveSize); | ||
wb.NMTReleaseMemory(addr2, reserveSize); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear we are only releasing the original mappings to keep things consistent? And we could do this before reserving the new three region mapping - right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not applicable in new approach. PR description is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay - I think I follow that.
Thanks
@afshin-zafari - I have ProblemListed this test on all platforms to reduce any noise |
The test expects that two disjunct regions are reserved but checked it incompletely.
It is fixed by reserving a new (third) region with the required size and then released the middle region among these three regions.
In Windows, it is not possible/valid to release middle regions. Either a whole region or a region that has the same end-address with the whole region can be released. IOW, only 'release the whole' or 'release from address A up to the end' are valid.
Since it (reserving two regions that become adjacent) is not happening always, the test failed occasionally at different tiers.
Tested local linux-x64-debug.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25894/head:pull/25894
$ git checkout pull/25894
Update a local copy of the PR:
$ git checkout pull/25894
$ git pull https://git.openjdk.org/jdk.git pull/25894/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25894
View PR using the GUI difftool:
$ git pr show -t 25894
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25894.diff
Using Webrev
Link to Webrev Comment