8353815: [ubsan] compilationPolicy.cpp: division by zero related to tiered compilation flags

[mhaessig]

A run of runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java with an ubsan enabled binary revealed that passing the value 0 to Tier(3|4)LoadFeedback, and TieredRateUpdateMinTime lead to division by zero.

Since Tier(3|4)LoadFeedback should disable the scaling of the compilation thresholds, 8bf37ee special cases the 0 case to disable scaling and documents it accordingly.

4893b28 sets the lower limit for TieredRateUpdate(Min|Max)Time to 1 since the code assumes that at least 1ms passes between each event:

jdk/src/hotspot/share/compiler/compilationPolicy.cpp

Lines 968 to 974 in c4fb00a

	// We should be running for at least 1ms.
	if (delta_s >= TieredRateUpdateMinTime) {
	// And we must've taken the previous point at least 1ms before.
	if (delta_t >= TieredRateUpdateMinTime && delta_e > 0) {
	method->set_prev_time(t);
	method->set_prev_event_count(event_count);
	method->set_rate((float)delta_e / (float)delta_t); // Rate is events per millisecond

This PR was tested with:

• Github Actions
• tier1 and 2 plus Oracle internal testing on Oracle supported platforms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353815: [ubsan] compilationPolicy.cpp: division by zero related to tiered compilation flags (Bug - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25902/head:pull/25902
$ git checkout pull/25902

Update a local copy of the PR:
$ git checkout pull/25902
$ git pull https://git.openjdk.org/jdk.git pull/25902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25902

View PR using the GUI difftool:
$ git pr show -t 25902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25902.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353815: [ubsan] compilationPolicy.cpp: division by zero related to tiered compilation flags

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• c51bed7: 8335986: Test javax/swing/JCheckBox/4449413/bug4449413.java fails on Windows 11 x64 because RBMenuItem's and CBMenuItem's checkmark on the left side are not visible
• a6464b7: 8358578: Small -XX:NMethodSizeLimit triggers "not in CodeBuffer memory" assert in C1
• 0dd50db: 8359825: Parallel: Simplify MutableNUMASpace::ensure_parsability
• ... and 21 more: https://git.openjdk.org/jdk/compare/57266064a7bb995c3c614c19b936687af35e9aa4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4893b288)