8365532: java/lang/module/ModuleReader/ModuleReaderTest.testImage fails

[david-beaumont]

This should fix this issue and locally fixes the test() method in:

test/jdk/java/lang/module/ModuleReader/ModuleReaderTest.java

which does:

---

        // test nulls
        try {
            reader.find(null);
            assertTrue(false);
        } catch (NullPointerException expected) { }

---

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365532: java/lang/module/ModuleReader/ModuleReaderTest.testImage fails (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26780/head:pull/26780
$ git checkout pull/26780

Update a local copy of the PR:
$ git checkout pull/26780
$ git pull https://git.openjdk.org/jdk.git pull/26780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26780

View PR using the GUI difftool:
$ git pr show -t 26780

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26780.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@david-beaumont This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365532: java/lang/module/ModuleReader/ModuleReaderTest.testImage fails

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• b0f98df: 8365416: java.desktop no longer needs preview feature access
• dd113c8: 8364628: Serial: Refactor SerialHeap::mem_allocate_work
• 4152099: 8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine
• ... and 14 more: https://git.openjdk.org/jdk/compare/f3b34d32d6ea409f8c8f0382e8f01e746366f842...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@david-beaumont The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ac4d9a59)

[david-beaumont]

/integrate

[openjdk]

@david-beaumont
Your change (at version ac4d9a5) is now ready to be sponsored by a Committer.

[sendaoYan]

/sponsor

I think we should integrate this PR right now to avoid the test noisy.

[openjdk]

Going to push as commit 44b19c0.
Since your change was applied there have been 23 commits pushed to the master branch:

• a65f200: 8365512: Replace -Xcomp with -Xmixed for AOT assembly phase
• 8c363b3: 8364319: Move java.lang.constant.AsTypeMethodHandleDesc to jdk.internal
• c5cbcac: 8361730: The CodeBuilder.trying(BlockCodeBuilder,CatchBuilder) method generates corrupted bytecode in certain cases
• ... and 20 more: https://git.openjdk.org/jdk/compare/f3b34d32d6ea409f8c8f0382e8f01e746366f842...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan @david-beaumont Pushed as commit 44b19c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.