8367382: Expand use of representation equivalence terminology #27232

jddarcy · 2025-09-11T17:56:29Z

Small doc enhancement to use the term "representation equivalence" in a few more locations.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8367382: Expand use of representation equivalence terminology (Enhancement - P4)

Reviewers

Raffaello Giulietti (@rgiulietti - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27232/head:pull/27232
$ git checkout pull/27232

Update a local copy of the PR:
$ git checkout pull/27232
$ git pull https://git.openjdk.org/jdk.git pull/27232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27232

View PR using the GUI difftool:
$ git pr show -t 27232

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27232.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-09-11T17:57:31Z

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-11T17:59:01Z

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367382: Expand use of representation equivalence terminology

Reviewed-by: rgiulietti

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

e2eaa2e: 8357708: com.sun.jndi.ldap.Connection ignores queued LDAP replies if Connection is subsequently closed
3eb3e0d: 8366833: Poly1305 does not always correctly update position for array-backed ByteBuffers after processMultipleBlocks
35dabb1: 8244336: Restrict algorithms at JCE layer
... and 16 more: https://git.openjdk.org/jdk/compare/e172e6a4e37cf06afee662625a01193f5528a2b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-09-11T18:00:07Z

@jddarcy The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-09-11T18:04:55Z

Webrevs

eirbjo · 2025-09-11T19:10:57Z

src/java.base/share/classes/java/lang/Record.java

-     * Apart from the semantics described above, the precise algorithm
+     * Note that these rules imply that {@linkplain
+     * Double##repEquivalence representation equivalence} is used for
+     * the equality comparison of both for primitive floating-point


«of both for»?

Whoops; thanks for finding that typo. Fixed in subsequent push.

rgiulietti · 2025-09-12T08:51:18Z

src/java.base/share/classes/java/lang/Double.java

@@ -1455,6 +1457,13 @@ public int compareTo(Double anotherDouble) {
     *    Double.valueOf(d1).compareTo(Double.valueOf(d2))
     * </pre>
     *
+     * @apiNote
+     * One idiom to implement {@linkplain
+     * Double##repEquivalence representation equivalence} on {@code


Suggested change

* Double##repEquivalence representation equivalence} on {@code

* ##repEquivalence representation equivalence} on {@code

for consistency with the similar change in equals()

rgiulietti · 2025-09-12T08:51:22Z

src/java.base/share/classes/java/lang/Float.java

@@ -871,6 +871,8 @@ public static int hashCode(float value) {
     * same if and only if the method {@link #floatToIntBits(float)}
     * returns the identical {@code int} value when applied to
     * each.
+     * In other words, {@linkplain ##repEquivalence representation


Suggested change

* In other words, {@linkplain ##repEquivalence representation

* In other words, {@linkplain Double##repEquivalence representation

I think the class name is needed here.

Correct and fixed. (I though the javac/javadoc doctlint checks should catch that kind of problem, but apparently not.) Thanks.

jddarcy · 2025-09-15T16:20:31Z

/integrate

openjdk · 2025-09-15T16:22:39Z

Going to push as commit 58c9fbc.
Since your change was applied there have been 32 commits pushed to the master branch:

e8dda2b: 8367629: Parallel: Remove logging in PSAdjustWeakRootsClosure
a7dc011: 8366658: Add missing locks when accessing the VirtualMemoryTracker instance in tests and MemMapPrinter
1cb1267: 8361711: Add library name configurability to PKCS11Test.java
... and 29 more: https://git.openjdk.org/jdk/compare/e172e6a4e37cf06afee662625a01193f5528a2b1...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-09-15T16:23:01Z

@jddarcy Pushed as commit 58c9fbc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8367382: Expand use of representation equivalence terminology

0a4d8f2

openjdk bot changed the title ~~JDK-8367382: Expand use of representation equivalence terminology~~ 8367382: Expand use of representation equivalence terminology Sep 11, 2025

openjdk bot added core-libs [email protected] rfr Pull request is ready for review labels Sep 11, 2025

eirbjo reviewed Sep 11, 2025

View reviewed changes

Fix typo found in code review.

5c7c92b

rgiulietti reviewed Sep 12, 2025

View reviewed changes

Respond to review feedback.

1a327d9

rgiulietti approved these changes Sep 13, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2025

openjdk bot added the integrated Pull request has been integrated label Sep 15, 2025

openjdk bot closed this Sep 15, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8367382: Expand use of representation equivalence terminology #27232

8367382: Expand use of representation equivalence terminology #27232

Uh oh!

jddarcy commented Sep 11, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Sep 11, 2025

Uh oh!

openjdk bot commented Sep 11, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Sep 11, 2025

Uh oh!

mlbridge bot commented Sep 11, 2025 •

edited

Loading

Uh oh!

eirbjo Sep 11, 2025

Uh oh!

jddarcy Sep 12, 2025

Uh oh!

rgiulietti Sep 12, 2025

Uh oh!

rgiulietti Sep 12, 2025

Uh oh!

jddarcy Sep 12, 2025

Uh oh!

jddarcy commented Sep 15, 2025

Uh oh!

openjdk bot commented Sep 15, 2025

Uh oh!

openjdk bot commented Sep 15, 2025

Uh oh!

Uh oh!

	* Double##repEquivalence representation equivalence} on {@code
	* ##repEquivalence representation equivalence} on {@code

	* In other words, {@linkplain ##repEquivalence representation
	* In other words, {@linkplain Double##repEquivalence representation

8367382: Expand use of representation equivalence terminology #27232

8367382: Expand use of representation equivalence terminology #27232

Uh oh!

Conversation

jddarcy commented Sep 11, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 11, 2025

Uh oh!

openjdk bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 11, 2025

Uh oh!

mlbridge bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

eirbjo Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

jddarcy Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

rgiulietti Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

rgiulietti Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

jddarcy Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

jddarcy commented Sep 15, 2025

Uh oh!

openjdk bot commented Sep 15, 2025

Uh oh!

openjdk bot commented Sep 15, 2025

Uh oh!

Uh oh!

jddarcy commented Sep 11, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Sep 11, 2025 •

edited

Loading

mlbridge bot commented Sep 11, 2025 •

edited

Loading