Skip to content

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Sep 12, 2025

Disable the default handling of Ctrl+C in the parent app launcher process to let the child app launcher running JVM handle it. Add corresponding test case.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365790: Shutdown hook for application image does not work on Windows (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27264/head:pull/27264
$ git checkout pull/27264

Update a local copy of the PR:
$ git checkout pull/27264
$ git pull https://git.openjdk.org/jdk.git pull/27264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27264

View PR using the GUI difftool:
$ git pr show -t 27264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27264.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365790: Shutdown hook for application image does not work on Windows

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs [email protected] rfr Pull request is ready for review labels Sep 12, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2025

Webrevs

@sashamatveev
Copy link
Member

Looks good. I assume parent process will terminate as well after child process?

@alexeysemenyukoracle
Copy link
Member Author

Thank you for the review. The child process will automatically terminate when the parent terminates and vice versa.

The fix disables Ctrl+C event handling in the parent process to let the child process handle it. When a Ctrl+C event occurs, the child process running the JVM terminates, automatically terminating the parent process.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants