Skip to content

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 3, 2025

Added a small test to check the size of ICC profile data after serialization.
For standard profiles, the size should stay small (under 200 bytes) because the real data is not stored.
For custom profiles, the size depends on the real data plus a small overhead.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369032: Add test to ensure serialized ICC_Profile stores only necessary optional data (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27616/head:pull/27616
$ git checkout pull/27616

Update a local copy of the PR:
$ git checkout pull/27616
$ git pull https://git.openjdk.org/jdk.git pull/27616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27616

View PR using the GUI difftool:
$ git pr show -t 27616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27616.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review October 4, 2025 02:38
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 4, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant