Skip to content

Conversation

merykitty
Copy link
Member

@merykitty merykitty commented Oct 3, 2025

Hi,

This PR improves the implementation of AndNode/OrNode/XorNode::Value by taking advantages of the additional information in TypeInt. The implementation is pretty straightforward. A clever trick is that by analyzing the negative and positive ranges of a TypeInt separately, we have better info for the leading bits. I also implement gtest unit tests to verify the correctness and monotonicity of the inference functions.

Please take a look and leave your reviews, thanks a lot.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367341: C2: apply KnownBits and unsigned bounds to And / Or operations (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27618/head:pull/27618
$ git checkout pull/27618

Update a local copy of the PR:
$ git checkout pull/27618
$ git pull https://git.openjdk.org/jdk.git pull/27618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27618

View PR using the GUI difftool:
$ git pr show -t 27618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27618.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2025

👋 Welcome back qamai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@merykitty The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant