8367341: C2: apply KnownBits and unsigned bounds to And / Or operations #27618
+611
−329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR improves the implementation of
AndNode/OrNode/XorNode::Value
by taking advantages of the additional information inTypeInt
. The implementation is pretty straightforward. A clever trick is that by analyzing the negative and positive ranges of aTypeInt
separately, we have better info for the leading bits. I also implement gtest unit tests to verify the correctness and monotonicity of the inference functions.Please take a look and leave your reviews, thanks a lot.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27618/head:pull/27618
$ git checkout pull/27618
Update a local copy of the PR:
$ git checkout pull/27618
$ git pull https://git.openjdk.org/jdk.git pull/27618/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27618
View PR using the GUI difftool:
$ git pr show -t 27618
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27618.diff
Using Webrev
Link to Webrev Comment