Skip to content

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Oct 3, 2025

This PR corrects two instances of Charset.isSupported which were inadvertently converted to Charset.forName in test/jdk/java/nio/charset/Charset/IllegalCharsetName.java during JDK-8369078.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8369078: Fix faulty test conversion in IllegalCharsetName.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27631/head:pull/27631
$ git checkout pull/27631

Update a local copy of the PR:
$ git checkout pull/27631
$ git pull https://git.openjdk.org/jdk.git pull/27631/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27631

View PR using the GUI difftool:
$ git pr show -t 27631

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27631.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2025

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369078: Fix faulty test conversion in IllegalCharsetName.java

Reviewed-by: naoto, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8369078: Fix faulty test conversion in IllegalCharsetName.java 8369078: Fix faulty test conversion in IllegalCharsetName.java Oct 3, 2025
@openjdk
Copy link

openjdk bot commented Oct 3, 2025

@justin-curtis-lu The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nio [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants